From: Minchan Kim <minchan@kernel.org>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitalywool@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] zram: update zram to use zpool
Date: Thu, 16 Jun 2016 08:17:32 +0900 [thread overview]
Message-ID: <20160615231732.GJ17127@bbox> (raw)
In-Reply-To: <efcf047e747d9d1e80af16ebfc51ea1964a7a621.1466000844.git.geliangtang@gmail.com>
On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
> Change zram to use the zpool api instead of directly using zsmalloc.
> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
> I did the following two things to fix it.
> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
> call zs_compact() in zsmalloc.
> 2) The 'pages_compacted' attribute is showed in zram by calling
> zs_pool_stats(). So in order not to call zs_pool_state() I move the
> attribute to zsmalloc.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
NACK.
I already explained why.
http://lkml.kernel.org/r/20160609013411.GA29779@bbox
next prev parent reply other threads:[~2016-06-15 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMJBoFPA_7G4nEeaPzL6uAvewpvgAYMmJ-A2FwfDSYVyOBfShA@mail.gmail.com>
2016-06-15 14:42 ` [PATCH] zram: add zpool support v2 Geliang Tang
2016-06-15 14:42 ` [PATCH] zram: update zram to use zpool Geliang Tang
2016-06-15 14:54 ` Dan Streetman
2016-06-15 15:33 ` kbuild test robot
2016-06-15 23:17 ` Minchan Kim [this message]
2016-06-17 8:30 ` Vitaly Wool
2016-06-17 12:28 ` Austin S. Hemmelgarn
2016-06-20 8:00 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615231732.GJ17127@bbox \
--to=minchan@kernel.org \
--cc=ddstreet@ieee.org \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox