From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932548AbcFOXRc (ORCPT ); Wed, 15 Jun 2016 19:17:32 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:55987 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbcFOXRb (ORCPT ); Wed, 15 Jun 2016 19:17:31 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 16 Jun 2016 08:17:32 +0900 From: Minchan Kim To: Geliang Tang CC: Nitin Gupta , Sergey Senozhatsky , Dan Streetman , Vitaly Wool , , Subject: Re: [PATCH] zram: update zram to use zpool Message-ID: <20160615231732.GJ17127@bbox> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/06/16 08:17:26, Serialize by Router on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/06/16 08:17:26, Serialize complete at 2016/06/16 08:17:26 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote: > Change zram to use the zpool api instead of directly using zsmalloc. > The zpool api doesn't have zs_compact() and zs_pool_stats() functions. > I did the following two things to fix it. > 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to > call zs_compact() in zsmalloc. > 2) The 'pages_compacted' attribute is showed in zram by calling > zs_pool_stats(). So in order not to call zs_pool_state() I move the > attribute to zsmalloc. > > Signed-off-by: Geliang Tang NACK. I already explained why. http://lkml.kernel.org/r/20160609013411.GA29779@bbox