From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753361AbcFOXaX (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 19:30:23 -0400
Received: from LGEAMRELO13.lge.com ([156.147.23.53]:55138 "EHLO
	lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753172AbcFOXaW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 19:30:22 -0400
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 165.244.98.76
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.223.161
X-Original-MAILFROM: minchan@kernel.org
Date: Thu, 16 Jun 2016 08:30:28 +0900
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
CC: Arnd Bergmann <arnd@arndb.de>, Vlastimil Babka <vbabka@suse.cz>,
        Michal Hocko <mhocko@suse.com>,
        Hillf Danton <hillf.zj@alibaba-inc.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: compaction: fix dummy declarations
Message-ID: <20160615233028.GK17127@bbox>
References: <20160615213929.36528-1-arnd@arndb.de>
 <20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org>
MIME-Version: 1.0
In-Reply-To: <20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/06/16 08:30:18,
	Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/06/16 08:30:18,
	Serialize complete at 2016/06/16 08:30:18
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On Wed, Jun 15, 2016 at 02:48:25PM -0700, Andrew Morton wrote:
> On Wed, 15 Jun 2016 23:39:12 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > We get a build error in several test builds after a recent code rework:
> > 
> > In file included from include/linux/balloon_compaction.h:48:0,
> >                  from mm/balloon_compaction.c:11:
> > include/linux/compaction.h:237:122: error: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > 
> > The patch that likely introduced the problem added a forward declaration
> > for 'struct node' in linux/compaction.h, but only in one of two instances.
> > 
> > This moves the declaration out of the #ifdef so we always get it.
> 
> http://ozlabs.org/~akpm/mmots/broken-out/mm-balloon-use-general-non-lru-movable-page-feature-fix.patch
> should fix this.  I guess I should do another -mm.
> 

[1] solves the issues so we can revert your patch with removing remaining
forward declaration in below code snippet.
If I should resend patch with removing remainiang forward declaration part,
please tell me.

Thanks.

compaction.h:

#if defined(CONFIG_COMPACTION) && defined(CONFIG_SYSFS) && defined(CONFIG_NUMA)
struct node; <----- Here
extern int compaction_register_node(struct node *node);
...
#else
...

#endif /* CONFIG_COMPACTION && CONFIG_SYSFS && CONFIG_NUMA */


[1] http://ozlabs.org/~akpm/mmots/broken-out/mm-fix-build-warnings-in-linux-compactionh.patch

Thanks.