From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754209AbcFPKjD (ORCPT ); Thu, 16 Jun 2016 06:39:03 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36919 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbcFPKi4 (ORCPT ); Thu, 16 Jun 2016 06:38:56 -0400 Date: Thu, 16 Jun 2016 11:39:37 +0100 From: Lee Jones To: "Andrew F. Davis" Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG Message-ID: <20160616103937.GT4948@dell> References: <20160613150800.6302-1-afd@ti.com> <20160615154303.GN4948@dell> <57617A1D.3050502@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57617A1D.3050502@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun 2016, Andrew F. Davis wrote: > On 06/15/2016 10:43 AM, Lee Jones wrote: > > This requires a USB Ack. > > > >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. > >> Add MFD core support. > >> > >> Signed-off-by: Andrew F. Davis > >> --- > > > > Where is the change log from v1 => v2? > > > > Looking at a diff of the two it looks like all the changes are related > to your v1 feedback: > > - Rename sm-usb-dig -> ti-smusbdig > - Inline helper functions in header > - Alphabetize includes Please ensure this is added when you submit subsequent sets. It really does help with the review and saves a great deal of time. > >> Changes from v2: > >> - Add missing dependency on USB, thanks kbuild test robot > >> > >> drivers/mfd/Kconfig | 9 +++ > >> drivers/mfd/Makefile | 2 + > >> drivers/mfd/ti-smusbdig.c | 138 ++++++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/ti-smusbdig.h | 75 ++++++++++++++++++++++ > >> 4 files changed, 224 insertions(+) > >> create mode 100644 drivers/mfd/ti-smusbdig.c > >> create mode 100644 include/linux/mfd/ti-smusbdig.h > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog