From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbcFPKkx (ORCPT ); Thu, 16 Jun 2016 06:40:53 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36063 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986AbcFPKkv (ORCPT ); Thu, 16 Jun 2016 06:40:51 -0400 Date: Thu, 16 Jun 2016 11:41:32 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Chanwoo Choi , Krzysztof Kozlowski Subject: Re: [RESEND RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Message-ID: <20160616104132.GV4948@dell> References: <1464280340-13228-1-git-send-email-javier@osg.samsung.com> <1464280340-13228-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464280340-13228-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 May 2016, Javier Martinez Canillas wrote: > The driver's init function is called at subsys init call level but the > dependencies provided by the driver are looked up by drivers that have > probe deferral support, so manual ordering of init calls isn't needed. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > > --- > Hello, > > I checked an the only users in mainline for this driver are the Exynos3250 > Monk and Rinato boards. In both, only two regulators are used (safeout_reg > and motor_reg) and these are looked up by the drivers phy-samsung-usb2 and > regulator-haptic respectively, and both support probe deferral. > > Best regards, > Javier > > drivers/mfd/max14577.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c > index 2280b3fdcf68..6c245128ab2e 100644 > --- a/drivers/mfd/max14577.c > +++ b/drivers/mfd/max14577.c > @@ -561,7 +561,7 @@ static int __init max14577_i2c_init(void) > > return i2c_add_driver(&max14577_i2c_driver); > } > -subsys_initcall(max14577_i2c_init); > +module_init(max14577_i2c_init); > > static void __exit max14577_i2c_exit(void) > { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog