From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753889AbcFPL1Z (ORCPT ); Thu, 16 Jun 2016 07:27:25 -0400 Received: from mail-am1on0109.outbound.protection.outlook.com ([157.56.112.109]:6112 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751275AbcFPL1W (ORCPT ); Thu, 16 Jun 2016 07:27:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Thu, 16 Jun 2016 14:10:53 +0300 From: Vladimir Davydov To: Andy Lutomirski CC: "linux-kernel@vger.kernel.org" , , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Josh Poimboeuf , Johannes Weiner , Michal Hocko , Subject: Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks Message-ID: <20160616111053.GA13143@esperanza> References: <24279d4009c821de64109055665429fad2a7bff7.1466036668.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <24279d4009c821de64109055665429fad2a7bff7.1466036668.git.luto@kernel.org> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: DB5PR10CA0004.EURPRD10.PROD.OUTLOOK.COM (10.165.4.142) To VI1PR08MB0589.eurprd08.prod.outlook.com (10.163.169.19) X-MS-Office365-Filtering-Correlation-Id: 5c48fe3f-89d8-403e-59a9-08d395d6e655 X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0589;2:0pt8k/GddCuoCAF1ifOwqynYE+dH1IDR9RajUOn/GpkK1QDeyiMn3FTSnoIQPiUn1G1gn7k2OW7OyAQnAIfrPHJ44b1IfLGX4Z9IX9a9BQT/zIDCsp2Lg5/dA5jvurRyK6Q+6oVuclI/5k/SlSP93dUOMafBVHeUI+0gQ8Q0/e+7wznHJGDO8AaJpQZ5vRwH;3:Wn/7Wn/E7LBr7mmN2vq8peTzk13eEO5K/2f3xkDcNaaMFh9PFqyqqSghk/Xp3QHw9xCinpOwk5rhHxnC3nG9xW3059myNncn7lXwPAIj9xnrugg5GXDxHW7UV97+Qw0y;25:mBWjLJx6uj/h92Ejg4RMZfU35AX/+Ue8fuveJVUqvfB7tcOUOb1UouFAWQ7Aa40I+Y0kbMeiEpiXB0v6fZvxYj5EhnfL0vzRES4gBS8vFchYsF/BVfzUnwcYt4/z8J+r7rVTzKEdUmsNh+sMr0Rd6XASIgTh/EcFAuirmY0VTzuj8d3NG9FS08dXo0h+n55ypWILPcndrlto8bCsKt/bkGlZbGvdjHpaU/ZY8y1cFyiCDkx7xtcV8uLTk5YLgSxOsIaDA6VYWVqKCcsy5aRLEQ78UnZCba03/1NUk+B6eBs8QS/eb37/iiEjB+9eh5dlYCT1aAw4DyOEiIgQBU42G7gQI9KgDpWNeg9/77Ux8JEtjUGmhCLSzC4sTRSk/M3rrWLdIVP4rl828P7lz7swLU6y+BPpqqQyGGQr+reBSVw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0589; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046);SRVR:VI1PR08MB0589;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0589; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0589;4:QT+UdAaNK5JgLpS0AgMi/qqnq7blM37jYFGr4XZX+cXL7QGBSO5k4v8DGARb0sf7I4iPinfzhIw++ng9rKdpZxLZnFg4uBXs/xnHlz7pddrjaUOGT4pa9fbOHowUHJB9Tk5W8kgTZaQrBJRMiiypxMmKf3endPCQOoD1pauJReXSZGhLeaAWB3DJQwsu1JBrQVCWP8VYyfr/Q+aUAw/icj4ElOZZ29oWcx8fGzaWPqWZ47h3Zjitq4ueDiibRV6CNmbmUDUFXHoKTupuJ/KiBng17bCe3zHXFHJ5Te22LwtUHGd0yp3yMbg2+xwQHUF33qunAbsAdiSAdAb9kj01yFU8/qpiUxJS7JAFEXaow+NXg9Sd3SY3ULw7aEZQlWP3xP74AoQcxvVrc/Qrj+v2TWAGJKNCh5Zk44N3tu0lPtc= X-Forefront-PRVS: 09752BC779 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(97736004)(105586002)(80792005)(77096005)(2950100001)(47776003)(81166006)(8676002)(2906002)(4326007)(1076002)(81156014)(42186005)(106356001)(76176999)(54356999)(50986999)(5008740100001)(5004730100002)(86362001)(101416001)(46406003)(3846002)(50466002)(586003)(6116002)(33716001)(23726003)(68736007)(97756001)(66066001)(189998001)(110136002)(92566002)(9686002)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB0589;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR08MB0589;23:ygrn65AzsKcFklbjvuih6eGxBmbpGurlLdbw/NUhI?= =?us-ascii?Q?CLajDR8AhPSpFlYXh/+6DehIbAAKHJUul94I29eydNNSVpbfA9RvZ69TrDpL?= =?us-ascii?Q?QFySzch98GTn7DCzZ/cInC7I8I1qJhZLnyZZbgWloENSsNDRCAOgKeFLIT80?= =?us-ascii?Q?5ZQ1jWKvA8TLAiAg0ss2QJ1RcqtMF45GASqY9WlJzDIzsM4KhikfO1Zwku8L?= =?us-ascii?Q?NdY0heQ47fG7aMV+K1sz9OMNDHppxZ0y8DFBxFZifpu1y5jNphNV9g8fXYjk?= =?us-ascii?Q?STZt3RT8tDig7SjZaBm+FKrUKreliDdLxkdOgK/zEcCM94GQW9pCqsEkbZcu?= =?us-ascii?Q?xwOcY9Ae8ts09/kzxiZXqij/Xvyt9HJGhbsawG/xd/ycL+xk5XetD+jyjTme?= =?us-ascii?Q?SdDA7u/wYQeqHpbNLMG2H3XN/sGjMFoQFNgVhPNjGV/lYoWq5KK2kDya6ME5?= =?us-ascii?Q?iXknH95uevp42BLP6npvI3Vr0BNdUPpk7sRVDrp6S1QTEUHjqjtU8oon4hLn?= =?us-ascii?Q?vtf6/+0/PFJth8SydmgPrp3OrKYy5FEq9a2GTw1SzelStkuD2X+bdZ0iU3jL?= =?us-ascii?Q?jVMWVN2wXqqbbPq+HCKQmN/VpJwYl6vaBgFuK4VohuJi2QDrdcbYd0imS/GK?= =?us-ascii?Q?IA4vO+jIGnLkx7fSsPdO4JxNL3ZMD/WBL6e/3Y3BrDvL51IR10QFJ2rVd26f?= =?us-ascii?Q?0T6VRz9vzot6J7YX3WiLLnnOrdUwVyV8FSRCfZ8GHXl3pVvC97komUCsy32J?= =?us-ascii?Q?LfqpS/GkpHxesr5A8d5zXHT47h/vXE2/UEPRnsPGvLbPeFNkE+jPxJxpdtta?= =?us-ascii?Q?KGY4dVbFHWhVHapc6LZdJEqRmMa6fciAybttSgTSSrpwO59pvSz5mGxYAoBU?= =?us-ascii?Q?7Qz5H/U1UD0iNFb2FhBLim6KSOGsAR0QhNV6pcVlQ2hXjtRC7rayWL6/H0si?= =?us-ascii?Q?rz3I88rMu9buwVCXCeH37JNzsw12pHrdQCf93V1GDO06Qlcjh0+BzURCIh86?= =?us-ascii?Q?FIfN7Tz+Kndk4ZmYBzKTUJo+awj6cihQigvubNnFlnzZgOzWPdxvKCw5nwPo?= =?us-ascii?Q?v8Bs5AmhMgvw3/0VGZhkegicbzR?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0589;6:q5eRNcPgLLbk1jf6MNh/2onqbgjLn3QeFwFIjy9GBvISM0NDPdBNilBF/vzc/sRoune/dIGSoTjtv1NKMn/vw1IJfmbUUxt7ECeRdztnK8eatTCH9XhcfjREpqB6z+nptIy37Svuy2nDfObpuAWFdSc+dMBYyEZRxi8pMjBc2xESvV/aZTEvvgq70df9DNdduaZ8PYyfa8LXBPs3YpHa0dR4U2qAcoNXNzk3LxRL0OaUE/Wy6LMvfxa636qyCSIDGypVHSq4yoduh7oKpBmGcCeOCUXAB0pkITxtJez/dI3xioRk55Oi0qcHgyHNsCq9;5:E6R40zeqY6ASiY2x1Fa+fim+PQ+VfDVhgQavIu8jiSLFo3HxeClx6RUHG4yiO9Xj1zR2fHfZXkLC40GbhGQRMGq4e9eEvDE4FfUa5jpXkF+E0dZ6deIocLtfKMl3htZeA4AIg+3iNgqsTXTPSaEb/A==;24:ojAmhC12PJQAoyaTxDZX3RXjfs91O6zyvQa3jz3dcG172FK4ugVH4CirRYQC3EyrNfpS5PkweusMDu9PYSF+Q3qAV92mKh/tk6kIGQqUUAc=;7:qHDT6b+eVO3Ll9ri9sVz+WhqrVSwuRlc3auZCqzKTNp70NYf5L765hzhKOfm1FEgx3iOPiK/GRZPBVCrCiybtTc42HCj+ZaM4EwanazlOi3ymLhBz/jousX+RU6AOuPAFqcXry+cdeWcfXZqBqNY+y66Y/M4z+ynGFNRKPheehB3qCo2fP1r8kRTAk+6oi2jgdxqUWNleEzuYYjoLjs3sQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0589;20:Wr3opHQJWP2pFuEbX6pSQEh6mPWQDksj3OHXInHYTQT3dLibYNa9VvT7ICP1Od6HS9d9vjxHi+iYI0Tbf5wjRSMMBoZRm2e+QFLeIj/1RMGv9bs0dw6/o0ctbRoY8HsxgNOhVVY/pcNvm8vPEV9bOK2l2fbDdr9cLISHJ24HT5E= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 11:10:59.0509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0589 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: ... > @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info *ti, int account) > { > struct zone *zone = page_zone(virt_to_page(ti)); > > - mod_zone_page_state(zone, NR_KERNEL_STACK, account); > + mod_zone_page_state(zone, NR_KERNEL_STACK, > + THREAD_SIZE / PAGE_SIZE * account); It won't work if THREAD_SIZE < PAGE_SIZE. Is there an arch with such a thread size, anyway? If no, we should probably drop thread_info_cache.