From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755185AbcFPO0Q (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jun 2016 10:26:16 -0400
Received: from mail-wm0-f50.google.com ([74.125.82.50]:38485 "EHLO
	mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754965AbcFPO0L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jun 2016 10:26:11 -0400
Date: Thu, 16 Jun 2016 15:26:46 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>,
        linux-kernel@vger.kernel.org, ysiyer <yegnesh.s.iyer@intel.com>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data
 structures
Message-ID: <20160616142646.GX4948@dell>
References: <20160611080844.GB92337@worksta>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160611080844.GB92337@worksta>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 11 Jun 2016, Bin Gao wrote:

> This patch adds three new data structures: struct trip_config_map {},
> struct thermal_irq_map {} and struct pmic_thermal_data {} which are
> required by some new drivers.
> 
> Signed-off-by: ysiyer <yegnesh.s.iyer@intel.com>
> Signed-off-by: Bin Gao <bin.gao@intel.com>
> ---
>  include/linux/mfd/intel_soc_pmic.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)

Please place the addition of the structs into the patches which use
them first.

> diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
> index cf619db..7df4302 100644
> --- a/include/linux/mfd/intel_soc_pmic.h
> +++ b/include/linux/mfd/intel_soc_pmic.h
> @@ -21,6 +21,27 @@
>  
>  #include <linux/regmap.h>
>  
> +struct trip_config_map {
> +	u16 irq_reg;
> +	u16 irq_en;
> +	u16 evt_stat;
> +	u8 irq_mask;
> +	u8 irq_en_mask;
> +	u8 evt_mask;
> +	u8 trip_num;
> +};
> +
> +struct thermal_irq_map {
> +	char handle[20];
> +	int num_trips;
> +	struct trip_config_map *trip_config;
> +};
> +
> +struct pmic_thermal_data {
> +	struct thermal_irq_map *maps;
> +	int num_maps;
> +};
> +
>  struct intel_soc_pmic {
>  	int irq;
>  	struct regmap *regmap;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog