From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbcFPP36 (ORCPT ); Thu, 16 Jun 2016 11:29:58 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33886 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079AbcFPP34 (ORCPT ); Thu, 16 Jun 2016 11:29:56 -0400 Date: Thu, 16 Jun 2016 16:30:32 +0100 From: Lee Jones To: Brian Norris Cc: Thierry Reding , Olof Johansson , linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Boris Brezillon , Stephen Barber , Javier Martinez Canillas , Benson Leung , Enric Balletbo , Randall Spangler , Shawn Nematbakhsh , Dmitry Torokhov , Todd Broch , Gwendal Grignou , Tomeu Vizoso Subject: Re: [PATCH v2 1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Message-ID: <20160616153032.GC21702@dell> References: <1464916904-37554-1-git-send-email-briannorris@chromium.org> <1464916904-37554-2-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464916904-37554-2-git-send-email-briannorris@chromium.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Jun 2016, Brian Norris wrote: > From: Tomeu Vizoso > > So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate > code when checking for errors from the EC side. > > Signed-off-by: Tomeu Vizoso > Reviewed-by: Benson Leung > Signed-off-by: Brian Norris > --- > v2: no change > > drivers/platform/chrome/cros_ec_proto.c | 15 +++++++++++++++ > include/linux/mfd/cros_ec.h | 18 ++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index b6e161f71b26..ecc544c728f0 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -380,3 +380,18 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, > return ret; > } > EXPORT_SYMBOL(cros_ec_cmd_xfer); > + > +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > + struct cros_ec_command *msg) > +{ > + int ret; > + > + ret = cros_ec_cmd_xfer(ec_dev, msg); > + if (ret < 0) > + dev_err(ec_dev->dev, "Command xfer error (err:%d)\n", ret); > + else if (msg->result != EC_RES_SUCCESS) > + return -EECRESULT - msg->result; > + > + return ret; > +} > +EXPORT_SYMBOL(cros_ec_cmd_xfer_status); > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 64184d27e3cd..b1e48dfbf50a 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -40,6 +40,9 @@ > #define EC_MAX_REQUEST_OVERHEAD 1 > #define EC_MAX_RESPONSE_OVERHEAD 2 > > +/* ec_command return value for non-success result from EC */ > +#define EECRESULT 1000 > + > /* > * Command interface between EC and AP, for LPC, I2C and SPI interfaces. > */ > @@ -226,6 +229,21 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, > struct cros_ec_command *msg); > > /** > + * cros_ec_cmd_xfer_status - Send a command to the ChromeOS EC > + * > + * This function is identical to cros_ec_cmd_xfer, except it returns succes s/succes/success/ I guess whoever takes this patch can do a quick fix-up job on it, so: Acked-by: Lee Jones > + * status only if both the command was transmitted successfully and the EC > + * replied with success status. It's not necessary to check msg->result when > + * using this function. > + * > + * @ec_dev: EC device > + * @msg: Message to write > + * @return: Num. of bytes transferred on success, <0 on failure > + */ > +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > + struct cros_ec_command *msg); > + > +/** > * cros_ec_remove - Remove a ChromeOS EC > * > * Call this to deregister a ChromeOS EC, then clean up any private data. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog