From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Yuyang Du <yuyang.du@intel.com>, Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Benjamin Segall <bsegall@google.com>,
Paul Turner <pjt@google.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group
Date: Thu, 16 Jun 2016 20:51:15 +0200 [thread overview]
Message-ID: <20160616185115.GL30921@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160616163013.GA32169@vingu-laptop>
On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote:
> With patch [1] for the init of cfs_rq side, all use cases will be
> covered regarding the issue linked to a last_update_time set to 0 at
> init
> [1] https://lkml.org/lkml/2016/5/30/508
Aah, wait, now I get it :-)
Still, we should put cfs_rq_clock_task(cfs_rq) in it, not 1. And since
we now acquire rq->lock on init this should well be possible. Lemme sort
that.
next prev parent reply other threads:[~2016-06-16 18:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 22:21 [PATCH v6 0/4] sched/fair: Fix attach and detach sched avgs for task group change and sched class change Yuyang Du
2016-06-14 22:21 ` [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group Yuyang Du
2016-06-15 7:46 ` Vincent Guittot
2016-06-15 0:18 ` Yuyang Du
2016-06-15 14:15 ` Vincent Guittot
2016-06-15 15:22 ` Peter Zijlstra
2016-06-16 1:00 ` Yuyang Du
2016-06-16 16:30 ` Vincent Guittot
2016-06-16 17:17 ` Peter Zijlstra
2016-06-16 18:57 ` Vincent Guittot
2016-06-16 18:51 ` Peter Zijlstra [this message]
2016-06-16 19:00 ` Vincent Guittot
2016-06-16 20:07 ` Peter Zijlstra
2016-06-16 21:21 ` Vincent Guittot
2016-06-17 2:12 ` Yuyang Du
2016-06-17 12:00 ` Vincent Guittot
2016-06-17 9:48 ` Peter Zijlstra
2016-06-17 11:31 ` Peter Zijlstra
2016-06-14 22:21 ` [PATCH v6 2/4] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du
2016-06-14 22:21 ` [PATCH v6 3/4] sched/fair: Skip detach sched avgs for new task when changing task groups Yuyang Du
2016-06-14 22:21 ` [PATCH v6 4/4] sched/fair: Add inline to detach_entity_load_evg() Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616185115.GL30921@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox