From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbcFPU2X (ORCPT ); Thu, 16 Jun 2016 16:28:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:33700 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754260AbcFPU2W (ORCPT ); Thu, 16 Jun 2016 16:28:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,481,1459839600"; d="scan'208";a="977314244" Date: Thu, 16 Jun 2016 22:28:23 +0200 From: Jarkko Sakkinen To: Sudip Mukherjee Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH] tpm: use devm_add_action_or_reset Message-ID: <20160616202823.GE1414@intel.com> References: <1465740329-4699-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465740329-4699-1-git-send-email-sudipm.mukherjee@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling put_device() to > free the resources allocated. Lets use the helper > devm_add_action_or_reset() and return directly in case of error, as we > know that the cleanup function has been already called by the helper if > there was any error. > > Signed-off-by: Sudip Mukherjee Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm-chip.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index 1965dc7..5a2f043 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -213,11 +213,11 @@ struct tpm_chip *tpmm_chip_alloc(struct device *pdev, > if (IS_ERR(chip)) > return chip; > > - rc = devm_add_action(pdev, (void (*)(void *)) put_device, &chip->dev); > - if (rc) { > - put_device(&chip->dev); > + rc = devm_add_action_or_reset(pdev, > + (void (*)(void *)) put_device, > + &chip->dev); > + if (rc) > return ERR_PTR(rc); > - } > > dev_set_drvdata(pdev, chip); > > -- > 1.9.1 >