From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH 2/6] memory: mvebu-devbus: make it explicitly non-modular
Date: Thu, 16 Jun 2016 20:37:44 -0400 [thread overview]
Message-ID: <20160617003748.12188-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160617003748.12188-1-paul.gortmaker@windriver.com>
The Kconfig for this option is currently:
config MVEBU_DEVBUS
bool "Marvell EBU Device Bus Controller"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity, so that when reading the
driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit. An
alternate init level might be worth considering at a later date.
We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/memory/mvebu-devbus.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/memory/mvebu-devbus.c b/drivers/memory/mvebu-devbus.c
index 24852812fd44..543eeec47bd1 100644
--- a/drivers/memory/mvebu-devbus.c
+++ b/drivers/memory/mvebu-devbus.c
@@ -2,6 +2,8 @@
* Marvell EBU SoC Device Bus Controller
* (memory controller for NOR/NAND/SRAM/FPGA devices)
*
+ * Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
+ *
* Copyright (C) 2013-2014 Marvell
*
* This program is free software: you can redistribute it and/or modify
@@ -19,7 +21,7 @@
*/
#include <linux/kernel.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/slab.h>
#include <linux/err.h>
#include <linux/io.h>
@@ -340,7 +342,6 @@ static const struct of_device_id mvebu_devbus_of_match[] = {
{ .compatible = "marvell,orion-devbus" },
{},
};
-MODULE_DEVICE_TABLE(of, mvebu_devbus_of_match);
static struct platform_driver mvebu_devbus_driver = {
.probe = mvebu_devbus_probe,
@@ -354,8 +355,4 @@ static int __init mvebu_devbus_init(void)
{
return platform_driver_register(&mvebu_devbus_driver);
}
-module_init(mvebu_devbus_init);
-
-MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Ezequiel Garcia <ezequiel.garcia@free-electrons.com>");
-MODULE_DESCRIPTION("Marvell EBU SoC Device Bus controller");
+device_initcall(mvebu_devbus_init);
--
2.8.4
next prev parent reply other threads:[~2016-06-17 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 0:37 [PATCH 0/6] memory: remove modular usage from non-modular drivers Paul Gortmaker
2016-06-17 0:37 ` [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular Paul Gortmaker
2016-06-17 7:30 ` Nicolas Ferre
2016-06-21 15:17 ` Alexandre Belloni
2016-06-17 0:37 ` Paul Gortmaker [this message]
2016-06-17 0:37 ` [PATCH 3/6] memory: omap-gpmc: " Paul Gortmaker
2016-06-17 7:26 ` Roger Quadros
2016-06-17 0:37 ` [PATCH 4/6] memory: tegra20-mc: " Paul Gortmaker
2016-06-17 0:37 ` [PATCH 5/6] memory: samsung/exynos-srom: " Paul Gortmaker
2016-06-20 7:50 ` Krzysztof Kozlowski
2016-06-17 0:37 ` [PATCH 6/6] memory: atmel-ebi: " Paul Gortmaker
2016-06-17 7:35 ` Nicolas Ferre
2016-06-17 7:38 ` Boris Brezillon
2016-06-21 15:18 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617003748.12188-3-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox