From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755235AbcFQDPV (ORCPT ); Thu, 16 Jun 2016 23:15:21 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:44204 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbcFQDPU (ORCPT ); Thu, 16 Jun 2016 23:15:20 -0400 Date: Fri, 17 Jun 2016 06:15:07 +0300 From: Baruch Siach To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, "moderated list:ARM/CONEXANT DIGI..." Subject: Re: [PATCH V2 11/63] clocksource/drivers/digitcolor: Convert init function to return error Message-ID: <20160617031507.GQ2749@tarshish> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-12-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466112442-31105-12-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Thu, Jun 16, 2016 at 11:26:30PM +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano It would be nice to have at least LAKL on Cc of the cover letter as well, so we can get the big picture. I found it at http://article.gmane.org/gmane.linux.kernel/2246137. But anyway, for this and the final patch: Acked-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -