From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161045AbcFQJ7d (ORCPT ); Fri, 17 Jun 2016 05:59:33 -0400 Received: from muru.com ([72.249.23.125]:56579 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343AbcFQJ7a (ORCPT ); Fri, 17 Jun 2016 05:59:30 -0400 Date: Fri, 17 Jun 2016 02:59:26 -0700 From: Tony Lindgren To: Keerthy Cc: robh+dt@kernel.org, mark.rutland@arm.com, d-gerlach@ti.com, nm@ti.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Franklin S Cooper Jr , Aparna Balasubramanian Subject: Re: [PATCH] ARM: dts: am437x-sk-evm: Reduce i2c0 bus speed for tps65218 Message-ID: <20160617095925.GD22406@atomide.com> References: <1465971328-16046-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465971328-16046-1-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Keerthy [160614 23:18]: > From: Dave Gerlach > > Based on the latest timing specifications for the TPS65218 from the data > sheet, http://www.ti.com/lit/ds/symlink/tps65218.pdf, document SLDS206 > from November 2014, we must change the i2c bus speed to better fit within > the minimum high SCL time required for proper i2c transfer. > > When running at 400khz, measurements show that SCL spends > 0.8125 uS/1.666 uS high/low which violates the requirement for minimum > high period of SCL provided in datasheet Table 7.6 which is 1 uS. > Switching to 100khz gives us 5 uS/5 uS high/low which both fall above > the minimum given values for 100 khz, 4.0 uS/4.7 uS high/low. > > Without this patch occasionally a voltage set operation from the kernel > will appear to have worked but the actual voltage reflected on the PMIC > will not have updated, causing problems especially with cpufreq that may > update to a higher OPP without actually raising the voltage on DCDC2, > leading to a hang. Applying into omap-for-v4.7/fixes thanks. Tony