From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbcFQKCm (ORCPT ); Fri, 17 Jun 2016 06:02:42 -0400 Received: from mail-bn1bon0090.outbound.protection.outlook.com ([157.56.111.90]:2318 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751711AbcFQKCk (ORCPT ); Fri, 17 Jun 2016 06:02:40 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.21) smtp.mailfrom=amd.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=permerror action=none header.from=amd.com; Date: Fri, 17 Jun 2016 18:07:47 +0800 From: Huang Rui To: Borislav Petkov CC: Vince Weaver , , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin Subject: Re: [patch] events/amd/power add support for fam16h model30h Message-ID: <20160617100746.GC13900@hr-amur2> References: <20160616211218.GC4002@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160616211218.GC4002@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.21;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(24454002)(199003)(189002)(87936001)(19580405001)(47776003)(26826002)(4001350100001)(33656002)(189998001)(586003)(23726003)(356003)(9686002)(92566002)(46406003)(19580395003)(11100500001)(76176999)(50986999)(54356999)(6806005)(83506001)(86362001)(105586002)(1076002)(106466001)(110136002)(101416001)(33716001)(97756001)(50466002)(2950100001)(5008740100001)(246002)(77096005)(8936002)(2906002)(4326007)(8676002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0851;H:SATLEXCHOV01.amd.com;FPR:;SPF:None;PTR:hybridsmtp.amd.com,hybridsmtp01.amd.com;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-MS-Office365-Filtering-Correlation-Id: a2812035-a5af-42f0-180d-08d39696827a X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0851;2:tcxC6w/v2g1elqXHtJvW0FL2FByHu5a062B6R7+r02rrrlT6Azwke/ade94V+GEIfs5BWJjCMkVA9YACnnfVYaa5Zt/KIOsNlqRKfPjkE71ucCPRcQG5kkyN9kq4qixUrUG4hxYYKrrxInY+SIYBLYkWHOeUlBeGaFl18iOQHR3H4PaZxauXlO3+V3XsaGIg;3:jH2qDcXN4y2igeBrS++BMPHiKvi4i/34VtS5R9ll5mgJofQRB/+3Hf8czhxKALQPJeP+Cu6ny1SCeXhwR4p+OR/rskB9WSkFYLlIyhs27RcXRKwvqH05Cr7vQPeKupqasIO043XAzyD8PtZ7buOe8wio5rLYSa/EaTLPHs98pkqRJTDXHGG7saBTrzMnHY8Fb1gLyjgcU+IxF3UaBvsEoOdo019RI8V1FbYsjRK4L4s=;25:U7O9/2nEuOuTRVplLcU3+IeP3MmLIfVnML45u+Pexu6W26OyWJ+Tl4DlXFAArmxZwX+lxH8yR+T8lnkxZqk/kLBmCia7456SKO1gn9ZeuMrw2AqlaP/YKLjJIRrbGLtbaT48Igim86t7NygJidAttlkwRpny59GfT+9zEAuP0xQ0cfpLsBcIrWcIMtJYN/ojedQ7uzf0dEvbWboIvZoXCMDp+oV7nJNLbUOYYu7RGRYueYHgh5JVlarVJDFUlmntbFIFFoObrIH080S0UzPsoXeqBT8tmL9ppZN/jpFce2m0CC2/MsNn+WcZxk1XiZ9jdNN24/gAq27+XndurHcWWNHumy3BcV/6ZOpmUAb7CE2TN1Kc8JQLFCzA2v+P7rQ/fPfS1950qgSRAtMedz/6+wz+8Zn4S3V7UaZMLiOuQyM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0851; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0851;20:NSRpIpuveXgRe20zAP9gd8PVMDepfc5ulwaRehTLPGEnIeFGgry32bmTdsSCKzXAlonf2bkv0+C4CxYqg9ApVYoErJPVRbWiK68+k5FsWLJypKF2+J1bpAcIcnyb/Gqxc6h/pwYN49lc4nc1SP8Cig7dsUsQjcf9Z6UeHzkMSq6raVzDpM7SFo0OyMNWrYi6BhVu6ZvSQl2zZqvW4lDBnZGnRD2E2h2tAI4slKnfWtsFauce13JC4QWmUX7DzpA9NFozpD4/Kj81YjPF8NrbV5In4JdKnUujqF+RX37f1/91Tga7rUcIcGstpO2iR4x2C/e0lRDjnd2u/0x2QwJs6aLvk91sOMoVKqKABtJu85A53YKWYovpbV9YKsC9seCOdu/Ri7jsztaV6pOL54I3zcbeDGHe/5kLiwu5rLBKEtygCfi3heK1j0l181Z0hrCqvFV1nAg/es3cU5uofjkkprfq8qK6Idm/cS9EmVnCqjXFRkoQ/2p9k9oYBZkIj7Bn;4:cUu1brQpKF5I/mvLLGO4tioS4A5a8QfmIyoIj6pnOOFWn7T7sq3dqyUSyTWIu8h2SnRCxojRVWQBESfCdiZ0t4Bwn8zyWYNACfSjWmmvh4Pb1+Gx/vpf19VJI+QwGmfhOn9dBxSjfLYxIowEZedW4uNq1YP+ckeLmIHENMGyQAhwlrs846PDU8u4/n9A0HAYjz9I2ovyn18jE+r4P/VU5ggQM/RRjDakrlwULX6HnzOWmT2EEzViLRKy8WPZrgk+AlSY2bbVvPdyVWbHE0rgRrFQvizPqkTe8SWiukom2AugcsnWCbwFgUZdkDJvWp+zNJxtYyzP0rRT+wzdXH/HJ5k+ZEZAIUpUtu6x1M4czosfhJz2XQvMao2wGNNGmNX7rIpvk/dpqhxv6+Augop1KzMGwfJ59U4GRpWyNa7zZgl4F4ZepEOk7m/W3B2+UV5X X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13021025)(5005006)(8121501046)(13013025)(13023025)(10201501046)(3002001)(6055026);SRVR:BN4PR12MB0851;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0851; X-Forefront-PRVS: 09760A0505 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0851;23:6y3Zhi0E/Yz2bbS+RBcvXskH+3uJLZqtlggr4ori1?= =?us-ascii?Q?xfEuGz+GW6/36CPVsNbiNqgK++5zCwF9LrPNedZf+84kwok5BRcZ/9jDiA2f?= =?us-ascii?Q?mhSf2kM0f7Sl2E3vc3OZxlZDej4UBJxjtfbpyq3ZMRJ65FNopaDLJYGeWipj?= =?us-ascii?Q?2jcDDTvtOQmnBgk4nTgrFGsiCmn1YnUbq2sd9Yb4durKtWaZGLkl7WiEHOrw?= =?us-ascii?Q?4iUAeWpeuyidNBGOR3s1PddZTRx+SZ3t/+ZtzxmAeDfGzJzyQnf88LXY4Ip/?= =?us-ascii?Q?vqrhfNYNOYCpk6G3nV5udKYNAMHLi5lg/Oix/Pt84yg1JSbTPvmeL3U835Zs?= =?us-ascii?Q?OqJAZRGe+YmGSaqiupxyBa5r11UeMUNxQ+pAh4c2buApg6qzFnw21n4NVpb6?= =?us-ascii?Q?E1ZdPRtXsoBgizKmwsJn3PDNYw+H6iAKyMVzSVwEAh+8R4rciNIZAQWGzJxR?= =?us-ascii?Q?M7oDv9iFflF166Ph6b6fk9tMoFBC5IZ6MyVjgfqUByNyZK1Z5xiyBGd9PYXh?= =?us-ascii?Q?XOgM4u1qgF6BRNMfnW7kZf0IObA/ugdR234dMxjkcUtWRfY5FsO1qDdUkbHh?= =?us-ascii?Q?Dvh4Uti4rf/PrNvD6Rktz3zdk/8v2P+5JkVUyKTrjmfcQMBltUJVk9yZ5gh8?= =?us-ascii?Q?SzMnF2Gy9Kqi0WnbeFvjpHX67a6U22OLahUwqC+VwAbR9n5BCGQgLx0QGBMp?= =?us-ascii?Q?soMx6zfmEhCgtPyK4RbfGYX7BWMT9gqS0BKUKc3L7MXmCsElrGY++fcT8351?= =?us-ascii?Q?D3aWjfYEv1V9zMG6TdZDkaloDudlZlCxRrYv2gANS/XIkoGBvZAYevxkngXH?= =?us-ascii?Q?BHPmmcJ4gF6X/0J5QeSXHdwQWWITcaBCq+dApm0915ILSb5ZHOIs2WTtpsP2?= =?us-ascii?Q?eGGTUJodY6CdVY4WMtnoN2WyTgB0BsOmbQ+OX0NSN6ta4PISzv0ycPX2tigW?= =?us-ascii?Q?nhsMq531M9+u9u11KcWL1+W+X37/CNv2Q9ait8gpJFmDYJmaXhMOzhNseSkz?= =?us-ascii?Q?10WVKjBdrov6NIFJGkZ40rBa44bWW8hL1FNHoo+D54Q8hzVsIcU6gpUXsDmA?= =?us-ascii?Q?+bDmx4LqSiFj+CpbK2EzqxOzruSbT5ShV7TlIOBr5ZibKhu2c/fCLUviBMDw?= =?us-ascii?Q?gpU+ZHLsl57AIOKt9CsxRaDtxWA967vGrEUcMrUXVvCq5utRQmuuw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0851;6:BqdPP01gSJuCrPOIIN3iAaOxXFIcWeD76j4Bs0TOGog7GIBHyBWCjlFA2DRbsWwNyoz4LyCX72uN9rRrknmuZ8SFT7mMJJHjQor1OCBeSD8ZEDNHH95lInzLbAcGnqUvH6bVKwSyCnJo85eakd0B9QDAuPAEJiAfRdmVScPrr1zLzxI2ATmjr+plvWuyvarLQrERsfWtlHITBsUqFcW7wtW0zhQZB+z+TwXfBA//TeWW3t2PXxHNgmROzltFs3pasbl5eHqbAsQCD5zFZyP7XrdnyAn43HQIpoZrAuHBVFV8KebdT0yPPIz4q1CfTK7kYTU/17PmKH5VFz4TMJhtGA==;5:7yeueaIf1jDq4y0dVedF2kOFUOCKF9uDtVD4eJ+NGjAbNFC5vAV3Ju0DVLkQXvjCP7CBDZv90FPz9MV/0Gn7p8PCENJrtpGiAFtj2AYCQq1HapozOe6TNJvI/4bMmWx9Bf/avQfjCzN0YRk0QWZE9Q==;24:doizdGWB/rIWmDHfvxo7+34XB7yd45nHDpI196elvCY4L0yRaJC0NvvjGANeugfoQA2L2D/EDjn+J/LTANN6XfRnS9UlCIlbHI9exz0KIPI=;7:WcW/dyI/IB0KfSlMVGOOd0MCL4miV6pfAezulanQPlvtMgdUb8FdySon/dE4ls2yR2zqNc/Vip9WrTWx9039H/3/PhODYP1PvTQ3TElbtOkWT7A9L3IzP8+t7Qb69k/J/uzXh8Kp4zdGbXZxKr4uS1XS5hyawzuB1q67wVwuSiGIVK1sSbmvi7p5fkHUgP/BPxw/AUmJuRxWWpbUvjMHcg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0851;20:zYOKcabm85MQ98lNkyZtePcAMPyQC4qX5R0n7hqfz0fG+FR0QHldBp6ggpmdbz4JUZv4psgfli3lUAPul4tq4KEMnCwbcnTwwYnAo3DCdRRTre9W8374MsgZEjMSscc90KH6InlET+F+jnwQej+zL4o+yXiRKVnTATCsTJAGIVdoACFi3JSgzVXUZSnL1Joq6kUpSxPHfNmBcyt5QxT04tAXg3NohDEeOYx5Rglcjt1oJX4loBieBBIFoSidrEjH X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2016 10:02:36.3922 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.21];Helo=[SATLEXCHOV01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0851 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 11:12:18PM +0200, Borislav Petkov wrote: > On Thu, Jun 16, 2016 at 05:00:04PM -0400, Vince Weaver wrote: > > > > According to the BKDG the AMD Family16h Model30h "Jaguar Mullins" > > also supports the accumulated power interface. I've tested on > > hardware I have and with this patch I indeed get power readings using > > perf. > > > > Signed-off-by: Vince Weaver > > > > diff --git a/arch/x86/events/amd/power.c b/arch/x86/events/amd/power.c > > index 55a3529..778b77d 100644 > > --- a/arch/x86/events/amd/power.c > > +++ b/arch/x86/events/amd/power.c > > @@ -292,6 +292,7 @@ static struct notifier_block power_cpu_notifier_nb = { > > > > static const struct x86_cpu_id cpu_match[] = { > > { .vendor = X86_VENDOR_AMD, .family = 0x15 }, > > + { .vendor = X86_VENDOR_AMD, .family = 0x16 }, > > {}, > > Actually, I think we remove that table completely and rely solely on the > CPUID bit: > > if (!boot_cpu_has(X86_FEATURE_ACC_POWER)) > return -ENODEV; > > Rui? > Agree with you. If the some chips are not stable, we can add a check to ignore them with family and model id. Thanks, Rui