From: Borislav Petkov <bp@alien8.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [patch] events/amd/power add support for fam16h model30h
Date: Fri, 17 Jun 2016 12:31:57 +0200 [thread overview]
Message-ID: <20160617103156.GA15997@pd.tnic> (raw)
In-Reply-To: <20160617100746.GC13900@hr-amur2>
On Fri, Jun 17, 2016 at 06:07:47PM +0800, Huang Rui wrote:
> Agree with you. If the some chips are not stable, we can add a check
> to ignore them with family and model id.
So if family 0x16 is not "stable" as you say, we probably should keep
the cpu_match array too.
Actually, you could merge the feature check in there too, AFAICT, from
looking at x86_match_cpu() and if I'm not misreading it:
static const struct x86_cpu_id cpu_match[] = {
{ .vendor = X86_VENDOR_AMD, .family = 0x15, .model = X86_MODEL_ANY, .feature = X86_FEATURE_ACC_POWER },
};
And then you can drop the boot_cpu_has() test as x86_match_cpu() does it
for you.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-06-17 10:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 21:00 [patch] events/amd/power add support for fam16h model30h Vince Weaver
2016-06-16 21:12 ` Borislav Petkov
2016-06-17 10:07 ` Huang Rui
2016-06-17 10:31 ` Borislav Petkov [this message]
2016-06-17 15:56 ` Vince Weaver
2016-06-17 16:27 ` Borislav Petkov
2016-06-17 17:38 ` Vince Weaver
2016-06-17 18:19 ` Borislav Petkov
2016-06-17 18:58 ` Vince Weaver
2016-06-17 19:41 ` Vince Weaver
2016-06-17 19:57 ` Borislav Petkov
2016-06-17 19:51 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617103156.GA15997@pd.tnic \
--to=bp@alien8.de \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox