From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933369AbcFQJ6r (ORCPT ); Fri, 17 Jun 2016 05:58:47 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33438 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753362AbcFQJ6q (ORCPT ); Fri, 17 Jun 2016 05:58:46 -0400 Date: Fri, 17 Jun 2016 11:58:38 +0200 From: luca abeni To: Juri Lelli Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org Subject: Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160617115838.0f3191c0@utopia> In-Reply-To: <1466156921-12417-1-git-send-email-juri.lelli@arm.com> References: <1466156921-12417-1-git-send-email-juri.lelli@arm.com> Organization: university of trento X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 17 Jun 2016 10:48:41 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them to setup a new dl_entity. > > Remove the second, useless, parameter. Funnily enough, I was adding something similar in my local queue :) Looks good to me Thanks, Luca > > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Luca Abeni > Signed-off-by: Juri Lelli > --- > kernel/sched/deadline.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index fcb7f0217ff4..5229788a4765 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -346,8 +346,7 @@ static void check_preempt_curr_dl(struct rq *rq, > struct task_struct *p, > * one, and to (try to!) reconcile itself with its own scheduling > * parameters. > */ > -static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se, > - struct sched_dl_entity *pi_se) > +static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se) > { > struct dl_rq *dl_rq = dl_rq_of_se(dl_se); > struct rq *rq = rq_of_dl_rq(dl_rq); > @@ -367,8 +366,8 @@ static inline void setup_new_dl_entity(struct > sched_dl_entity *dl_se, > * future; in fact, we must consider execution overheads > (time > * spent on hardirq context, etc.). > */ > - dl_se->deadline = rq_clock(rq) + pi_se->dl_deadline; > - dl_se->runtime = pi_se->dl_runtime; > + dl_se->deadline = rq_clock(rq) + dl_se->dl_deadline; > + dl_se->runtime = dl_se->dl_runtime; > } > > /* > @@ -1721,7 +1720,7 @@ static void switched_from_dl(struct rq *rq, > struct task_struct *p) static void switched_to_dl(struct rq *rq, > struct task_struct *p) { > if (dl_time_before(p->dl.deadline, rq_clock(rq))) > - setup_new_dl_entity(&p->dl, &p->dl); > + setup_new_dl_entity(&p->dl); > > if (task_on_rq_queued(p) && rq->curr != p) { > #ifdef CONFIG_SMP