Re: [PATCH 16/27] mm: Move page mapped accounting to the node

Mel Gorman
2016-06-16T16:04:58Z

On Thu, Jun 16, 2016 at 05:52:59PM +0200, Vlastimil Babka wrote:
> On 06/09/2016 08:04 PM, Mel Gorman wrote:
> >Reclaim makes decisions based on the number of file pages that are mapped but
> >it's mixing node and zone information. Account NR_FILE_MAPPED pages on the node.
>
> And NR_ANON_PAGES.
>

Yes.

> >Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> I've noticed some new "page_zone(page)->zone_pgdat" instances here.
>

FWIW, I created a page_pgdat helper and converted all patterns like this
introduced by the series to the helper. There are other potential users
of the helper in the tree that are not touched by the patches but I left
them to preserve history.

--
Mel Gorman
SUSE Labs