Re: [PATCH 22/27] mm: Convert zone_reclaim to node_reclaim

Vlastimil Babka
2016-06-17T10:55:16Z

On 06/09/2016 08:04 PM, Mel Gorman wrote:
> As reclaim is now per-node based, convert zone_reclaim to be node_reclaim.
> It is possible that a node will be reclaimed multiple times if it has
> multiple zones but this is unavoidable without caching all nodes traversed
> so far. The documentation and interface to userspace is the same from
> a configuration perspective and will will be similar in behaviour unless
> the node-local allocation requests were also limited to lower zones.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

[...]

> @@ -682,6 +674,14 @@ typedef struct pglist_data {
> */
> unsigned long totalreserve_pages;
>
> +#ifdef CONFIG_NUMA
> + /*
> + * zone reclaim becomes active if more unmapped pages exist.

node reclaim

> + */
> + unsigned long min_unmapped_pages;
> + unsigned long min_slab_pages;
> +#endif /* CONFIG_NUMA */
> +
> /* Write-intensive fields used from the page allocator */
> ZONE_PADDING(_pad1_)
> spinlock_t lru_lock;

[...]

> @@ -3580,7 +3580,7 @@ static inline unsigned long node_unmapped_file_pages(struct pglist_data *pgdat)
> }
>
> /* Work out how many page cache pages we can reclaim in this reclaim_mode */
> -static unsigned long zone_pagecache_reclaimable(struct zone *zone)
> +static unsigned long zone_pagecache_reclaimable(struct pglist_data *pgdat)

Rename to node_pagecache_reclaimable?