From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161370AbcFQPgo (ORCPT ); Fri, 17 Jun 2016 11:36:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54179 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755694AbcFQPgl (ORCPT ); Fri, 17 Jun 2016 11:36:41 -0400 Date: Fri, 17 Jun 2016 08:36:40 -0700 From: Greg Kroah-Hartman To: Kees Cook Cc: Arnd Bergmann , LKML Subject: Re: [PATCH] lkdtm: avoid link error on ARM Message-ID: <20160617153640.GA24643@kroah.com> References: <20160617100745.1956133-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 08:33:00AM -0700, Kees Cook wrote: > On Fri, Jun 17, 2016 at 3:07 AM, Arnd Bergmann wrote: > > The lkdtm_rodata file is built so that a function in it gets linked into > > the .rodata ELF section. This works fine normally, but on 32-bit ARM > > with really large kernels, it prevents the linker from inserting a > > veneer for the call to __gnu_mcount_nc in case we are building with > > "gcc -pg": > > > > drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing': > > panel.c:(.rodata+0x1480): relocation truncated to fit: R_ARM_CALL against symbol `__gnu_mcount_nc' defined in .text section in arch/arm/kernel/built-in.o > > > > We probably never want the profiling code to be enabled for this file > > anyway, so this just removes the option here, and for the sake of > > consistency also in the lkdtm core module. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 9a49a528dcf3 ("lkdtm: add function for testing .rodata section") > > Looks fine to me, thanks! > > Acked-by: Kees Cook > > Greg, can you take this into your tree for -next? Yes,will do.