From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbcFQTKS (ORCPT ); Fri, 17 Jun 2016 15:10:18 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35260 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbcFQTKQ (ORCPT ); Fri, 17 Jun 2016 15:10:16 -0400 Date: Fri, 17 Jun 2016 21:10:11 +0200 From: Richard Cochran To: Arnd Bergmann Cc: Chris Metcalf , y2038@lists.linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tilegx: use correct timespec64 type Message-ID: <20160617191011.GA10171@localhost.localdomain> References: <20160617161540.1362545-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617161540.1362545-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 06:15:30PM +0200, Arnd Bergmann wrote: > The conversion to the 64-bit time based ptp methods left two instances > of 'struct timespec' in place. This is harmless because 64-bit > architectures define timespec64 as timespec, and this driver is > not used on 32-bit machines. > > However, using 'struct timespec64' directly is obviously the right > thing to do, and will help us remove 'struct timespec' in the future. > > Signed-off-by: Arnd Bergmann > Fixes: b9acf24f779c ("ptp: tilegx: convert to the 64 bit get/set time methods.") Acked-by: Richard Cochran