From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbcFQTjC (ORCPT ); Fri, 17 Jun 2016 15:39:02 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:36739 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcFQTjA (ORCPT ); Fri, 17 Jun 2016 15:39:00 -0400 Date: Fri, 17 Jun 2016 15:38:56 -0400 From: Matt Ullman To: Randy Dunlap , Linus Torvalds Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib: Make strreplace prototype compatible with C++ Message-ID: <20160617193856.GA25433@staticfox.net> Reply-To: 57644395.9010505@infradead.org References: <20160617172412.9644-1-staticfox@staticfox.net> <57644395.9010505@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57644395.9010505@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 11:38:13AM -0700, Randy Dunlap wrote: > I didn't see and could not find any reply to v1. Who is that comment > addressed to? Linus? Yes, this was addressed to Linus. He CC'd the mailing list, but I could not find it either. Here is what he wrote: > Please only change the prototype, not the function. Might as well remove > the argument names in the prototype. > > Let's not make the C code uglier for no reason. The fact that C++ screwed > up and thought that "new" can't be used as a variable name is no reason not > to do it in C code. > > Similarly, we don't make C code use the insane C++ pointer caring rules. > > Linus -- Matt Ullman