From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933362AbcFQT57 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 15:57:59 -0400
Received: from mail.skyhub.de ([78.46.96.112]:41047 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753605AbcFQT55 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 15:57:57 -0400
Date: Fri, 17 Jun 2016 21:57:54 +0200
From: Borislav Petkov <bp@alien8.de>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Huang Rui <ray.huang@amd.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [patch] events/amd/power add support for fam16h model30h
Message-ID: <20160617195754.GP3912@pd.tnic>
References: <alpine.DEB.2.20.1606161655440.2744@macbook-air>
 <20160616211218.GC4002@pd.tnic>
 <20160617100746.GC13900@hr-amur2>
 <20160617103156.GA15997@pd.tnic>
 <alpine.DEB.2.20.1606171154340.20990@macbook-air>
 <20160617162728.GC3912@pd.tnic>
 <alpine.DEB.2.20.1606171334220.20990@macbook-air>
 <20160617181906.GM3912@pd.tnic>
 <alpine.DEB.2.20.1606171456420.20990@macbook-air>
 <alpine.DEB.2.20.1606171539410.21482@macbook-air>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.20.1606171539410.21482@macbook-air>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 17, 2016 at 03:41:38PM -0400, Vince Weaver wrote:
> FWIW on the trinity machine (F15hM13h) with your patch applied I get the 
> following:
> 
> vince@a10:~$ sensors
> k10temp-pci-00c3
> Adapter: PCI adapter
> temp1:         +0.0°C  (high = +70.0°C)
>                        (crit = +70.0°C, hyst = +69.0°C)
> 
> fam15h_power-pci-00c4
> Adapter: PCI adapter
> power1:           N/A  (crit = 100.04 W)

Yeah, I didn't expect to be that easy.

Provided hw support on TN is present, someone needs to sit down and
audit the algorithm in show_power() and sanity-check all those values
coming from the PCI regs.

But I'd wait for Rui first to confirm whether it is even worth to chase
this or whether TN is a lost cause because this TDP mechanism is not
supported there or whatever other reason there might be...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.