From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964841AbcFQVmk (ORCPT ); Fri, 17 Jun 2016 17:42:40 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:40435 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932469AbcFQVmh (ORCPT ); Fri, 17 Jun 2016 17:42:37 -0400 Date: Fri, 17 Jun 2016 14:41:51 -0700 From: Guenter Roeck To: Brian Norris Cc: Lee Jones , Thierry Reding , Olof Johansson , linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Boris Brezillon , Stephen Barber , Javier Martinez Canillas , Benson Leung , Enric Balletbo , Randall Spangler , Shawn Nematbakhsh , Dmitry Torokhov , Todd Broch , Gwendal Grignou , Tomeu Vizoso Subject: Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Message-ID: <20160617214151.GA1400@roeck-us.net> References: <1466193495-95801-2-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466193495-95801-2-git-send-email-briannorris@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 12:58:12PM -0700, Brian Norris wrote: > From: Tomeu Vizoso > > So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate > code when checking for errors from the EC side. > > Signed-off-by: Tomeu Vizoso > Reviewed-by: Benson Leung > Signed-off-by: Brian Norris > Acked-by: Lee Jones > Tested-by: Enric Balletbo i Serra > --- > v3: > * successfully spell success > > v2: > * no change > --- > drivers/platform/chrome/cros_ec_proto.c | 15 +++++++++++++++ > include/linux/mfd/cros_ec.h | 18 ++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index b6e161f71b26..ecc544c728f0 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -380,3 +380,18 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, > return ret; > } > EXPORT_SYMBOL(cros_ec_cmd_xfer); > + > +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > + struct cros_ec_command *msg) > +{ > + int ret; > + > + ret = cros_ec_cmd_xfer(ec_dev, msg); > + if (ret < 0) > + dev_err(ec_dev->dev, "Command xfer error (err:%d)\n", ret); > + else if (msg->result != EC_RES_SUCCESS) > + return -EECRESULT - msg->result; I have been wondering about the error return codes here, and if they should be converted to standard Linux error codes. For example, I just hit error -1003 with a driver I am working on. This translates to EC_RES_INVALID_PARAM, or, in Linux terms, -EINVAL. I think it would be better to use standard error codes, especially since some of the errors are logged. Guenter