From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbcFREBp (ORCPT ); Sat, 18 Jun 2016 00:01:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35266 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbcFREBn (ORCPT ); Sat, 18 Jun 2016 00:01:43 -0400 Date: Fri, 17 Jun 2016 21:01:43 -0700 From: Greg KH To: Ian Abbott Cc: Ashwin Ravichandran , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Message-ID: <20160618040143.GD5854@kroah.com> References: <1464772775-57175-1-git-send-email-ashwinravichandran24@gmail.com> <574EAC7D.9070001@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <574EAC7D.9070001@mev.co.uk> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2016 at 10:35:57AM +0100, Ian Abbott wrote: > On 01/06/16 10:19, Ashwin Ravichandran wrote: > > Fixed a coding style issue. > > > > Signed-off-by: Ashwin Ravichandran > > --- > > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- > > drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > > index 3757074..9c27999 100644 > > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > > @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev, > > data[0] != ADDIDATA_TIMER) > > return -EINVAL; > > > > - devpriv->tsk_Current = current; > > + devpriv->tsk_current = current; > > > > devpriv->timer_mode = data[0]; > > > > diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c > > index 40ff914..b2f6712 100644 > > --- a/drivers/staging/comedi/drivers/addi_apci_3501.c > > +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c > > @@ -68,7 +68,7 @@ > > struct apci3501_private { > > unsigned long amcc; > > unsigned long tcw; > > - struct task_struct *tsk_Current; > > + struct task_struct *tsk_current; > > unsigned char timer_mode; > > }; > > > > @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d) > > } > > > > /* Enable Interrupt Send a signal to from kernel to user space */ > > - send_sig(SIGIO, devpriv->tsk_Current, 0); > > + send_sig(SIGIO, devpriv->tsk_current, 0); > > ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG); > > ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG | > > ADDI_TCW_CTRL_IRQ_ENA); > > > > The patch looks fine (although this odd-ball Comedi driver shouldn't really > be sending signals to a user-space task!). Yeah, that's really odd, fixing that would be nice...