From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbcFRUUL (ORCPT ); Sat, 18 Jun 2016 16:20:11 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:51896 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbcFRUUJ (ORCPT ); Sat, 18 Jun 2016 16:20:09 -0400 Date: Sat, 18 Jun 2016 22:20:07 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Ben Dooks , Sergei Shtylyov Subject: Re: [PATCH v3 net-next v3 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock Message-ID: <20160618202007.GC7172@lunn.ch> References: <20160618000736.5598-1-vivien.didelot@savoirfairelinux.com> <20160618000736.5598-9-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160618000736.5598-9-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 08:07:30PM -0400, Vivien Didelot wrote: > The chip smi_mutex mutex is used to protect the access to the internal > switch registers, not only the Multi-chip Addressing Mode, as commented. > > Other registers access (like management frames) may use this mutex. > > Since we will isolate SMI-specific pieces of code, avoid the confusion > now by renaming smi_mutex to reg_lock. No functional changes here. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew