From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Craig Inches <craig@craiginches.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup
Date: Sat, 18 Jun 2016 19:02:35 -0700 [thread overview]
Message-ID: <20160619020235.GA18034@kroah.com> (raw)
In-Reply-To: <109b0da96b67ae70145433b585ada631a5f7c668.1466279901.git.craig@craiginches.com>
On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> Macros with complex values should be enclosed in parenthesis
>
> Signed-off-by: Craig Inches <craig@craiginches.com>
> ---
> drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ALWAYS test build your patches, to not do so just makes maintainers
grumpy...
Remember, checkpatch is a _hint_, it's not always right.
greg k-h
next prev parent reply other threads:[~2016-06-19 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 21:25 [PATCH 0/3] staging: luster: cl_object.h Checkpatch Cleanup Craig Inches
2016-06-18 21:25 ` [PATCH 1/3] " Craig Inches
2016-06-19 2:03 ` Greg Kroah-Hartman
2016-06-18 21:25 ` [PATCH 2/3] staging: luster: " Craig Inches
2016-06-18 23:39 ` kbuild test robot
2016-06-19 1:19 ` kbuild test robot
2016-06-19 1:46 ` kbuild test robot
2016-06-19 2:02 ` Greg Kroah-Hartman [this message]
2016-06-19 19:53 ` Craig Inches
2016-06-18 21:26 ` [PATCH 3/3] " Craig Inches
2016-06-19 2:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160619020235.GA18034@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=craig@craiginches.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox