From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbcFSCCh (ORCPT ); Sat, 18 Jun 2016 22:02:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44847 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbcFSCCg (ORCPT ); Sat, 18 Jun 2016 22:02:36 -0400 Date: Sat, 18 Jun 2016 19:02:35 -0700 From: Greg Kroah-Hartman To: Craig Inches Cc: Oleg Drokin , Andreas Dilger , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Message-ID: <20160619020235.GA18034@kroah.com> References: <109b0da96b67ae70145433b585ada631a5f7c668.1466279901.git.craig@craiginches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <109b0da96b67ae70145433b585ada631a5f7c668.1466279901.git.craig@craiginches.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > Macros with complex values should be enclosed in parenthesis > > Signed-off-by: Craig Inches > --- > drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) ALWAYS test build your patches, to not do so just makes maintainers grumpy... Remember, checkpatch is a _hint_, it's not always right. greg k-h