From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbcFSTxW (ORCPT ); Sun, 19 Jun 2016 15:53:22 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35992 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbcFSTxO (ORCPT ); Sun, 19 Jun 2016 15:53:14 -0400 Date: Sun, 19 Jun 2016 20:53:12 +0100 From: Craig Inches To: Greg Kroah-Hartman Cc: Oleg Drokin , Andreas Dilger , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Message-ID: <20160619195312.GA6855@voyager> References: <109b0da96b67ae70145433b585ada631a5f7c668.1466279901.git.craig@craiginches.com> <20160619020235.GA18034@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160619020235.GA18034@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I did build the kernel 1 for each change, then a final with all changes applied. Apologies if I missed something, Craig On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote: > On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > > Macros with complex values should be enclosed in parenthesis > > > > Signed-off-by: Craig Inches > > --- > > drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ALWAYS test build your patches, to not do so just makes maintainers > grumpy... > > Remember, checkpatch is a _hint_, it's not always right. > > greg k-h