From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753245AbcFTHhw (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 03:37:52 -0400
Received: from mga03.intel.com ([134.134.136.65]:53626 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751815AbcFTHhr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 03:37:47 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,497,1459839600"; 
   d="scan'208";a="125137694"
Date: Mon, 20 Jun 2016 10:37:24 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        Yegnesh S Iyer <yegnesh.s.iyer@intel.com>, Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver
Message-ID: <20160620073724.GS1739@lahna.fi.intel.com>
References: <20160616212208.GA60092@worksta>
 <20160617090342.GH1739@lahna.fi.intel.com>
 <20160620035431.GA236937@worksta>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160620035431.GA236937@worksta>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote:
> > > +#define DRV_NAME "bxt_wcove_gpio"
> > 
> > Drop this.
> We have _TWO_ places using DRV_NAME(near the end of the file):
> static struct platform_driver wcove_gpio_driver = {
>        .driver = {
>                .name = DRV_NAME,
>        },
> 
> and
> 
> MODULE_ALIAS("platform:" DRV_NAME);
> 
> You are suggesting to replace DRV_NAME with bxt_wcove_gpio(but why?)
> or something else?

Do instead this:

	.driver = {
		.name ="bxt_wcove_gpio",
	},

and

MODULE_ALIAS("platform:bxt_wcove_gpio");