From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbcFTI35 (ORCPT ); Mon, 20 Jun 2016 04:29:57 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43062 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752910AbcFTI3e (ORCPT ); Mon, 20 Jun 2016 04:29:34 -0400 Date: Mon, 20 Jun 2016 10:03:34 +0200 From: Alexandre Belloni To: "Yang, Wenyou" Cc: Rob Herring , Alan Stern , Greg Kroah-Hartman , "Ferre, Nicolas" , Pawel Moll , Mark Brown , Ian Campbell , Kumar Gala , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Message-ID: <20160620080334.GL5809@piout.net> References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <20160608202651.GA23604@rob-hp-laptop> <20160608203810.GF2466@piout.net> <20160617135448.GI5809@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote : > > Sure, what I mean is that you can try to get the regmap for the SFR in every case. > > Depending on whether you were able to get it, you can decide to call > > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL). > > I don't think so. The SFR includes a lot of miscellaneous functions, more than this one. > I know but this is irrelevant to this discussion. If you need to use the SFR from another driver you will simply get it from that other driver. I that case, you will try to get "atmel,sama5d2-sfr". It is only present on sama5d2 so you have enough information to know whether or not you can use it to suspend/resume. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com