From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798AbcFTPm7 (ORCPT ); Mon, 20 Jun 2016 11:42:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51622 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbcFTPms (ORCPT ); Mon, 20 Jun 2016 11:42:48 -0400 X-IBM-Helo: d01dlp02.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Mon, 20 Jun 2016 08:41:47 -0700 From: "Paul E. McKenney" To: Thomas Gleixner Cc: LKML , Ingo Molnar , Peter Zijlstra , Eric Dumazet , Frederic Weisbecker , Chris Mason , Arjan van de Ven , rt@linutronix.de, Rik van Riel , Linus Torvalds , George Spelvin , Len Brown Subject: Re: [patch V2 00/20] timer: Refactor the timer wheel Reply-To: paulmck@linux.vnet.ibm.com References: <20160617121134.417319325@linutronix.de> <20160620150555.GR3923@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062015-0044-0000-0000-00000072F11A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062015-0045-0000-0000-00000487FE9C Message-Id: <20160620154146.GS3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-20_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606200173 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 05:13:41PM +0200, Thomas Gleixner wrote: > On Mon, 20 Jun 2016, Paul E. McKenney wrote: > > > On Fri, Jun 17, 2016 at 01:26:28PM -0000, Thomas Gleixner wrote: > > > This is the second version of the timer wheel rework series. The first series > > > can be found here: > > > > > > http://lkml.kernel.org/r/20160613070440.950649741@linutronix.de > > > > > > The series is also available in git: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.timers > > > > Ran some longer rcutorture tests, and the scripting complained about > > hangs. This turned out to be due to the 12.5% uncertainty, so I fixed > > Is that stuff so sensitive? I'm surprised, because the old slack stuff got you > 6.25% already. But didn't you have to ask for slack? Anyway, rcutorture allows three minutes longer than the duration, and then kills the test (unless it is actively dumping the ftrace buffer). A 30-minute test does fine either way, but a 60-minute test gets killed with high probability. Changing to hrtimers makes things work nicely (other than SRCU), even for 60-minute runs. I have run ten-hour rcutorture runs with normal completion with the old timers. Might well be that this switch to hrtimer is needed in some situations for the old setup. Given that it happens only once per run, it clearly has little or no performance downside, so I am queueing it regardless. Well, I will do so once I take care of the arithmetic limitations that are causing link-time errors on 32-bit systems. Thanx, Paul