From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754254AbcFTQCA (ORCPT ); Mon, 20 Jun 2016 12:02:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753626AbcFTP7w (ORCPT ); Mon, 20 Jun 2016 11:59:52 -0400 Date: Mon, 20 Jun 2016 17:59:29 +0200 From: Jiri Olsa To: Peter Zijlstra Cc: Jiri Olsa , Ingo Molnar , lkml , James Hartsock , Rik van Riel , Srivatsa Vaddagiri , Kirill Tkhai Subject: Re: [PATCH 1/4] sched/fair: Introduce sched_entity::dont_balance Message-ID: <20160620155929.GA10167@krava> References: <1466424914-8981-1-git-send-email-jolsa@kernel.org> <1466424914-8981-2-git-send-email-jolsa@kernel.org> <20160620142823.GH30154@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160620142823.GH30154@twins.programming.kicks-ass.net> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 Jun 2016 15:59:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 04:28:23PM +0200, Peter Zijlstra wrote: > On Mon, Jun 20, 2016 at 02:15:11PM +0200, Jiri Olsa wrote: > > Adding dont_balance bool into struct sched_entity, > > to mark tasks which are rebalanced based on affinity. > > > > It's used only when REBALANCE_AFFINITY feature is > > switched on. The code functionality of this feature > > is introduced in following patch. > > > > Signed-off-by: Jiri Olsa > > --- > > include/linux/sched.h | 2 ++ > > kernel/sched/fair.c | 21 ++++++++++++++++++--- > > kernel/sched/features.h | 1 + > > 3 files changed, 21 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index dee41bf59e6b..0e6ac882283b 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1331,6 +1331,8 @@ struct sched_entity { > > > > u64 nr_migrations; > > > > + bool dont_balance; > > Never use bool in structures. ok, but I couldn't find anything real sinister about that.. so why is that? ;-) thanks, jirka