From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbcFTUAw (ORCPT ); Mon, 20 Jun 2016 16:00:52 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53886 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbcFTUAn (ORCPT ); Mon, 20 Jun 2016 16:00:43 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Mon, 20 Jun 2016 10:39:36 -0700 From: "Paul E. McKenney" To: SeongJae Park Cc: josh@joshtriplett.org, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] rcutorture: Remove outdated config option description Reply-To: paulmck@linux.vnet.ibm.com References: <1466376682-31378-1-git-send-email-sj38.park@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466376682-31378-1-git-send-email-sj38.park@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062017-0044-0000-0000-000000733F99 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062017-0045-0000-0000-000004884D59 Message-Id: <20160620173936.GU3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-20_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606200196 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 07:51:22AM +0900, SeongJae Park wrote: > CONFIG_RCU_TORTURE_TEST_RUNNABLE has removed by commit 4e9a073f60367 > ("torture: Remove CONFIG_RCU_TORTURE_TEST_RUNNABLE, simplify code") > entirely but the document has not updated. This commit updates the > document to remove the description for the config option and adding a > description for the alternative module parameter. > > Signed-off-by: SeongJae Park Good catch on CONFIG_RCU_TORTURE_TEST_RUNNABLE, queued for testing and review. I had to drop the other hunk for torture_runnable, though. This capability is instead controlled by several parameters that are documented in Documentation/kernel-parameters.txt. Thanx, Paul > --- > Documentation/RCU/torture.txt | 20 +++++--------------- > 1 file changed, 5 insertions(+), 15 deletions(-) > > diff --git a/Documentation/RCU/torture.txt b/Documentation/RCU/torture.txt > index 118e7c1..4bd9d86 100644 > --- a/Documentation/RCU/torture.txt > +++ b/Documentation/RCU/torture.txt > @@ -10,21 +10,6 @@ status messages via printk(), which can be examined via the dmesg > command (perhaps grepping for "torture"). The test is started > when the module is loaded, and stops when the module is unloaded. > > -CONFIG_RCU_TORTURE_TEST_RUNNABLE > - > -It is also possible to specify CONFIG_RCU_TORTURE_TEST=y, which will > -result in the tests being loaded into the base kernel. In this case, > -the CONFIG_RCU_TORTURE_TEST_RUNNABLE config option is used to specify > -whether the RCU torture tests are to be started immediately during > -boot or whether the /proc/sys/kernel/rcutorture_runnable file is used > -to enable them. This /proc file can be used to repeatedly pause and > -restart the tests, regardless of the initial state specified by the > -CONFIG_RCU_TORTURE_TEST_RUNNABLE config option. > - > -You will normally -not- want to start the RCU torture tests during boot > -(and thus the default is CONFIG_RCU_TORTURE_TEST_RUNNABLE=n), but doing > -this can sometimes be useful in finding boot-time bugs. > - > > MODULE PARAMETERS > > @@ -164,6 +149,11 @@ test_no_idle_hz Whether or not to test the ability of RCU to operate in > idle CPUs. Boolean parameter, "1" to test, "0" otherwise. > Defaults to omitting this test. > > +torture_runnable Start rcutorture at boot time in the case where the > + module is built into the kernel, otherwise wait for > + torture_runnable to be set via sysfs before starting. > + By default it will begin once the module is loaded. > + > torture_type The type of RCU to test, with string values as follows: > > "rcu": rcu_read_lock(), rcu_read_unlock() and call_rcu(), > -- > 1.9.1 >