From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbcFTXyd (ORCPT ); Mon, 20 Jun 2016 19:54:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48761 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754297AbcFTXy1 (ORCPT ); Mon, 20 Jun 2016 19:54:27 -0400 Date: Mon, 20 Jun 2016 16:54:25 -0700 From: Stephen Boyd To: Bjorn Andersson Cc: Andy Gross , David Brown , Greg Kroah-Hartman , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Message-ID: <20160620235425.GA1521@codeaurora.org> References: <1465844571-1229-1-git-send-email-bjorn.andersson@linaro.org> <1466101475-8851-1-git-send-email-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466101475-8851-1-git-send-email-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16, Bjorn Andersson wrote: > msm_set_termios() is called whenever the tty is opened. Setting the baud > rate requires a full reset of the msm serial block, even when the rate > is unchanged. In the case when the same uart is used as console this > reset will discard any console output data still being clocked out of > the TX fifo. > > By skipping the rate-change in the case where the baud rate is unchanged > since last request we can avoid the reset and the discarding of the > data. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project