From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933022AbcFUA7T (ORCPT ); Mon, 20 Jun 2016 20:59:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52111 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993AbcFUA7M (ORCPT ); Mon, 20 Jun 2016 20:59:12 -0400 Date: Mon, 20 Jun 2016 17:59:10 -0700 From: Stephen Boyd To: Jongsung Kim Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Chanho Min , Maxime Ripard Subject: Re: [RESEND][PATCH] clk: fixed-factor: set CLK_SET_RATE_PARENT Message-ID: <20160621005910.GN1521@codeaurora.org> References: <1465808880-12332-1-git-send-email-neidhard.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465808880-12332-1-git-send-email-neidhard.kim@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13, Jongsung Kim wrote: > Without CLK_SET_RATE_PARENT-flag set, clk_factor_round_rate() just > returns the current frequency. A fixed-factor-clock initialzed via > of_fixed_factor_clk_set() (ie, by device-tree) can't have the flag > set. It can be problematic when the parent of a fixed-factor-clock > is rate-controllable clk, because the rounding can't be propagated > to parent, the rounded target frequency is always the current, and > finally the frequency can't be changed. > > This patch sets the flags CLK_SET_RATE_PARENT for all fixed-factor- > clocks, from clk_register_fixed_factor(), and removes checking the > flag from clk_factor_round_rate(). > > Signed-off-by: Jongsung Kim > --- Hmm there's another patch for the same problem from Maxime[1] Mike replied there and said that it's worrisome to do this for all users of fixed factors clks, so perhaps you can set this flag when you register the clk instead? Or prove that all the users of this code in mainline are ok to change behavior. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/429726.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project