* [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate
@ 2016-06-08 9:50 honghui.zhang
2016-06-21 9:39 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: honghui.zhang @ 2016-06-08 9:50 UTC (permalink / raw)
To: joro, treding, mark.rutland, matthias.bgg, robh, robin.murphy
Cc: p.zabel, devicetree, pebolle, kendrick.hsu, arnd, srv_heupstream,
catalin.marinas, will.deacon, linux-kernel, tfiga, iommu, robh+dt,
djkurtz, kernel, linux-mediatek, linux-arm-kernel, l.stach,
yingjoe.chen, eddie.huang, youlin.pei, erin.lo, Honghui Zhang
From: Honghui Zhang <honghui.zhang@mediatek.com>
The device_node will be released in of_iommu_configure, it may be double
released if call of_node_put in mtk_iommu_of_xlate.
Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
drivers/iommu/mtk_iommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index c3043d8..493bd3e 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -455,7 +455,6 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
if (!dev->archdata.iommu) {
/* Get the m4u device */
m4updev = of_find_device_by_node(args->np);
- of_node_put(args->np);
if (WARN_ON(!m4updev))
return -EINVAL;
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate
2016-06-08 9:50 [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate honghui.zhang
@ 2016-06-21 9:39 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2016-06-21 9:39 UTC (permalink / raw)
To: honghui.zhang
Cc: treding, mark.rutland, matthias.bgg, robh, robin.murphy, p.zabel,
devicetree, pebolle, kendrick.hsu, arnd, srv_heupstream,
catalin.marinas, will.deacon, linux-kernel, tfiga, iommu, robh+dt,
djkurtz, kernel, linux-mediatek, linux-arm-kernel, l.stach,
yingjoe.chen, eddie.huang, youlin.pei, erin.lo
On Wed, Jun 08, 2016 at 05:50:44PM +0800, honghui.zhang@mediatek.com wrote:
> From: Honghui Zhang <honghui.zhang@mediatek.com>
>
> The device_node will be released in of_iommu_configure, it may be double
> released if call of_node_put in mtk_iommu_of_xlate.
>
> Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-21 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 9:50 [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate honghui.zhang
2016-06-21 9:39 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox