public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: esp8089: add new driver
Date: Tue, 21 Jun 2016 08:17:14 -0700	[thread overview]
Message-ID: <20160621151714.GA25462@kroah.com> (raw)
In-Reply-To: <523581466465724@web3g.yandex.ru>

On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> I cannot promise the code style (although I did indent -kr -i8).
> I cannot also promise the effect.

I don't understand this at all, sorry.

Why should we accept this driver?  Who is going to maintain it?  What
needs to be done to it?

And why are you top-posting?  :)

thanks,

greg k-h

  parent reply	other threads:[~2016-06-21 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160619123348.36735-1-icenowy@aosc.xyz>
2016-06-20 15:43 ` [PATCH v2] staging: esp8089: add new driver Greg KH
     [not found]   ` <523581466465724@web3g.yandex.ru>
2016-06-21 15:17     ` Greg KH [this message]
2016-08-21 15:09       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160621151714.GA25462@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=icenowy@aosc.xyz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox