From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbcFUPei (ORCPT ); Tue, 21 Jun 2016 11:34:38 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36374 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751871AbcFUPSH (ORCPT ); Tue, 21 Jun 2016 11:18:07 -0400 Date: Tue, 21 Jun 2016 17:17:28 +0200 From: Alexandre Belloni To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Nicolas Ferre Subject: Re: [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular Message-ID: <20160621151728.GU5809@piout.net> References: <20160617003748.12188-1-paul.gortmaker@windriver.com> <20160617003748.12188-2-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617003748.12188-2-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2016 at 20:37:43 -0400, Paul Gortmaker wrote : > The Kconfig for this option is currently: > > config ATMEL_SDRAMC > bool "Atmel (Multi-port DDR-)SDRAM Controller" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove the couple traces of modularity, so that when reading the > driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. An > alternate init level might be worth considering at a later date. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Alexandre Belloni > Cc: Nicolas Ferre > Signed-off-by: Paul Gortmaker > --- > drivers/memory/atmel-sdramc.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com