From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbcFUPTw (ORCPT ); Tue, 21 Jun 2016 11:19:52 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36422 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750707AbcFUPSb (ORCPT ); Tue, 21 Jun 2016 11:18:31 -0400 Date: Tue, 21 Jun 2016 17:18:29 +0200 From: Alexandre Belloni To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Boris Brezillon , Jean-Jacques Hiblot , Nicolas Ferre Subject: Re: [PATCH 6/6] memory: atmel-ebi: make it explicitly non-modular Message-ID: <20160621151829.GV5809@piout.net> References: <20160617003748.12188-1-paul.gortmaker@windriver.com> <20160617003748.12188-7-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617003748.12188-7-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2016 at 20:37:48 -0400, Paul Gortmaker wrote : > The Kconfig currently controlling compilation of this code is: > > drivers/memory/Kconfig:config ATMEL_EBI > drivers/memory/Kconfig: bool "Atmel EBI driver" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the few remaining modular references, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Boris Brezillon > Cc: Alexandre Belloni > Cc: Jean-Jacques Hiblot > Cc: Nicolas Ferre > Signed-off-by: Paul Gortmaker > --- > drivers/memory/atmel-ebi.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com