From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095AbcFUSGk (ORCPT ); Tue, 21 Jun 2016 14:06:40 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33255 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcFUSGi (ORCPT ); Tue, 21 Jun 2016 14:06:38 -0400 Date: Tue, 21 Jun 2016 14:06:29 -0400 From: Tejun Heo To: Kenny Yu Cc: lizefan@huawei.com, hannes@cmpxchg.org, cyphar@cyphar.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v4] cgroup: Add pids controller event when fork fails because of pid limit Message-ID: <20160621180629.GN3262@mtj.duckdns.org> References: <20160621172832.GM3262@mtj.duckdns.org> <1466531090-3539070-1-git-send-email-kennyyu@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466531090-3539070-1-git-send-email-kennyyu@fb.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 10:44:50AM -0700, Kenny Yu wrote: > This patch adds more visibility into the pids controller when the controller > rejects a fork request. Whenever fork fails because the limit on the number of > pids in the cgroup is reached, the controller will log this and also notify the > newly added cgroups events file. The `max` key in the events file represents > the number of times fork failed because of the pids controller. > > This change also logs only the first time the `max` event counter is > incremented. This is to provide a hint to the user to understand why fork > failed, as users are not yet used to seeing fork failures because of the > pids controller. > > Signed-off-by: Kenny Yu > Acked-by: Johannes Weiner cmpxchg.org> Applied to cgroup/for-4.8. Thanks! -- tejun