From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbcFUVev (ORCPT ); Tue, 21 Jun 2016 17:34:51 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33694 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbcFUVet (ORCPT ); Tue, 21 Jun 2016 17:34:49 -0400 Date: Tue, 21 Jun 2016 14:34:41 -0700 From: Omar Sandoval To: Kieran Bingham Cc: Jan Kiszka , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Message-ID: <20160621213441.GA12969@vader.DHCP.thefacebook.com> References: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com> <5769AF8E.8040807@bingham.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5769AF8E.8040807@bingham.xyz> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 10:20:14PM +0100, Kieran Bingham wrote: > On 21/06/16 22:11, Omar Sandoval wrote: > > From: Omar Sandoval > > > > Since scripts/gdb/linux/constants.py is autogenerated, this should have > > been added to .gitignore when it was introduced. > > > > Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants") > > Signed-off-by: Omar Sandoval > > --- > > Thanks, Kieran, I totally missed the comment in top-level .gitignore. > > > > scripts/gdb/linux/.gitignore | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore > > index 52e4e61140d1..d5abd6ce9425 100644 > > --- a/scripts/gdb/linux/.gitignore > > +++ b/scripts/gdb/linux/.gitignore > > @@ -1,2 +1,3 @@ > > *.pyc > > *.pyo > > +/constants.py > > Does this work with '/' at the beginning of the line? > It looks like all the other sub-tree .gitignores don't use a leading / > on their ignores > > If you're happy, I'd like to drop the leading '/'. > > (I think I can do this silently as I pick the patch if you approve, > rather than send another patch for a one-byte change) > > Other than that: > > Signed-off-by: Kieran Bingham > -- > Regards > > Kieran Bingham Yeah, it should still be relative to the path containing the .gitignore: ---- $ mkdir test $ cd test $ git init Initialized empty Git repository in /tmp/test/.git/ $ mkdir foo $ touch foo/bar $ git add foo/bar $ git commit -m "Initial commit" [master (root-commit) c9075695cce0] Initial commit 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 foo/bar $ touch asdf foo/asdf $ git status On branch master Untracked files: (use "git add ..." to include in what will be committed) asdf foo/asdf nothing added to commit but untracked files present (use "git add" to track) $ echo "/asdf" > foo/.gitignore $ git add foo/.gitignore $ git commit -m "Test" [master dc92ad57d7e8] Test 1 file changed, 1 insertion(+) create mode 100644 foo/.gitignore $ git status On branch master Untracked files: (use "git add ..." to include in what will be committed) asdf nothing added to commit but untracked files present (use "git add" to track) ---- tools/thermal/tmon/.gitignore also uses the leading slash. If you want to drop the /, I'm okay with it. -- Omar