From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbcFUWFb (ORCPT ); Tue, 21 Jun 2016 18:05:31 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33509 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbcFUWF3 (ORCPT ); Tue, 21 Jun 2016 18:05:29 -0400 Date: Tue, 21 Jun 2016 15:05:27 -0700 From: Omar Sandoval To: Kieran Bingham Cc: Jan Kiszka , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Message-ID: <20160621220527.GA20015@vader.DHCP.thefacebook.com> References: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com> <5769AF8E.8040807@bingham.xyz> <20160621213441.GA12969@vader.DHCP.thefacebook.com> <5769B9BB.2000806@bingham.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5769B9BB.2000806@bingham.xyz> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 11:03:39PM +0100, Kieran Bingham wrote: > On 21/06/16 22:34, Omar Sandoval wrote: > > $ git status > > On branch master > > Untracked files: > > (use "git add ..." to include in what will be committed) > > > > asdf > > > > nothing added to commit but untracked files present (use "git add" to track) > > ---- > > > > tools/thermal/tmon/.gitignore also uses the leading slash. > > Aha yes, > > find -name .gitignore -exec grep -Hin '^/' {} \; > ./tools/thermal/tmon/.gitignore:1:/tmon > ./.gitignore:44:/tags > ./.gitignore:45:/TAGS > ./.gitignore:46:/linux > ./.gitignore:47:/vmlinux > ./.gitignore:48:/vmlinux.32 > ./.gitignore:49:/vmlinux-gdb.py > ./.gitignore:50:/vmlinuz > ./.gitignore:51:/System.map > ./.gitignore:52:/Module.markers > ./.gitignore:57:/debian/ > ./.gitignore:62:/tar-install/ > > I think we'll call this the exception rather than the norm, and I'd > prefer to match the other 177 .gitignore files in their style. > > > > > If you want to drop the /, I'm okay with it. > > > Thanks for the testing, and checking. > Patch picked, and '/' silently dropped. Sounds good, thanks! -- Omar