From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcFUWuL (ORCPT ); Tue, 21 Jun 2016 18:50:11 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34211 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcFUWuH (ORCPT ); Tue, 21 Jun 2016 18:50:07 -0400 Date: Tue, 21 Jun 2016 15:32:11 -0700 From: Nicolin Chen To: Rob Herring Cc: broonie@kernel.org, lgirdwood@gmail.com, brian.austin@cirrus.com, Paul.Handrigan@cirrus.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, mark.rutland@arm.com Subject: Re: [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO Message-ID: <20160621223211.GA4287@Asurada-Nvidia> References: <1466474084-6775-1-git-send-email-nicoleotsuka@gmail.com> <20160621213437.GA3571@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160621213437.GA3571@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 04:34:37PM -0500, Rob Herring wrote: > On Mon, Jun 20, 2016 at 06:54:44PM -0700, Nicolin Chen wrote: > > The codec chip has a physical MUTE pin to let users control it via > > GPIO. So this patch add a mute control support to the driver. > > > > Signed-off-by: Nicolin Chen > > --- > > .../devicetree/bindings/sound/cs53l30.txt | 2 ++ > > sound/soc/codecs/cs53l30.c | 30 ++++++++++++++++++++++ > > sound/soc/codecs/cs53l30.h | 1 + > > 3 files changed, 33 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt > > index 18d6b99..6f7d3c8 100644 > > --- a/Documentation/devicetree/bindings/sound/cs53l30.txt > > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt > > @@ -13,6 +13,8 @@ Optional properties: > > > > - reset-gpios : a GPIO spec for the reset pin. > > > > + - mute-gpios : a GPIO spec for the MUTE pin. > > Please define the active state for the gpio. The active state here is programmable and being taken care by the driver automatically. Maybe I should have mentioned this in the binding as well? Thanks Nic