From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbcFVGCm (ORCPT ); Wed, 22 Jun 2016 02:02:42 -0400 Received: from mail-by2on0078.outbound.protection.outlook.com ([207.46.100.78]:2486 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750959AbcFVGCk (ORCPT ); Wed, 22 Jun 2016 02:02:40 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Wed, 22 Jun 2016 09:02:27 +0300 From: Yury Norov To: Joseph Myers CC: , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Message-ID: <20160622060227.GA22466@yury-N73SV> References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM3PR07CA0051.eurprd07.prod.outlook.com (10.141.45.179) To DM3PR07MB2251.namprd07.prod.outlook.com (10.164.33.149) X-MS-Office365-Filtering-Correlation-Id: 9cb7e734-12c5-47be-ab96-08d39a62cff9 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2251;2:NQes1reDVkZtN9sBoXONHbaBHwYtf2JZSQAwEPydoMTX1aMnpnL046JTswZDbu3smN6x33rR73PFhaF62hNnY+J1i63gv/Kt6NANNyM7fg7X7/kyNABDqbl8G8htxOsyMXt3pale1NtSQxFnq3FEKcrw8OiK8XggxSGHFyfiyv1dlkB6rMO6dV5O26ycsNrh;3:Yj2X1UEIPwbFKlobj6HRI3j/hoHn2o8cWytTEsJ2GUaE8+zTofs/N5ETfr+bMJnbvvKrDySGF+Ejf13vJun3IX6ggdeX74Wmn588H+QcoEfCYwXQgBe2+ggBJuJU6p+9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2251; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2251;25:s6ofx2veVrjQ4HYVl06s8NAhfQmSXD2N9KWiEvQ49hCeNTkXuw8N9myZ+0HdKcBzKPLe2RVJOyUhxeJWgwJFaH2Qkpt10vxCxdF9d+82GJO10SuppidyR2acP/g64BmNsUD0RUVz+haSmppHOv4mstOAvmmbjbSCTdE6TfIC/o6r5X327Pj8Y5nPdhz7Op0vYzL2BwOGBzvSYxB/8s/4BV8q0BlWa41SbePJCQfjLMX6jmehlaBLfG0Y5UUcvbacUHlXxCsVoDf+EusxM0w4GuZTANxkZ0dAgcnMkQkjKBqLsV3dGA2E5jS29FeHA6wH+icLDPHclKFaFexGBgGU/tpXnvxXjgXjr/nF54X6GJg/nSv6TA6Mgkt7oDWyBq2gWeMTrT4yN4eTTe6iakiUxdwLDlrII9OrlJD0WV8J0z9LRl/YQzvRuyox1r6tsu1I/oNYXbbXB5V6aGMhHB8duP1Mxdz6nLkjDcfK5/yTjI6fu/a0/oGilxFTvyeOZz+5kPVhPwXzJROoG7QceIDj33sAHnZMN461MjKTbyqRzBqbWbYkp1BBqS+FO8XY6mx5mfAFfTnR9DzOa7g0g2v4Y8OFFVk0q6f8La9VCc4u5FbsB+qfQejMaDK2icYqxF6YQkaQsvx6gKBiFDKOiOaGOGFFExe7aSRts6z/2YLBLO1BPFrErmrULCWdbLYf6swQbcpuMQpJG4Z80YBelYy9TF3PVhPfU6sr9tjoQOq9rkwqQBaXmAuLHfWUQY31viQW3PatO6PCC2sgrP0oqGw9kg== X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2251;20:pukdE8VFEcxWC/pLaz/bAksVAUTNZeybppyTvd9f14mc6LzxAXyCkkf9mYRX6Clbke0Rtlkd1qP6BhyVziy7Rah8gwDWKdiRZrByQJg/KLUiuwe/ihf7qzK37LWxF487LKgrmiOnI1VgDFRSOQ23+sMRYkZO4EmBmkTO9LXZmW4BAnosztkaWZDZ4J5kbevSPHv3gOV70iBp6pgVgxtFhGkNsYLt8wjjo7KGjmEtFrXuZC+nd9kz2hEU0sjwqbvK2tu7RXS+7con+GExr15mYCvxbDgsb+PcQgsUoXMG0IekeJDNKWQbUiCDmik8HG4muJ0uUxf+1h1fo824aEai8cFHK44MioLGgOqfUBo1p7PDHlKlpUCcSDJ+M0JzkQhlpnrXIVOMpQi4KatsPEThCOTwjnFIrSkg3QAOA8oFc6ypaRjEOO2BO7T1aSwIRqIMEoUyN1yCCDX9sDB+Omqs4aaZL1f6ywGq8fr9vBA7phLvPKv1S1RaXIEbMK8f07PPe8m4C0JXGrWvUw3Y/3LseLWGr+FSJ4MifMoI27mZoG3huyD77HYdFhl4Z4BCHJEUpwbLY3pc1Bsie2QIXlVwG3JdakvYCH21cfG8GUwvP+U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM3PR07MB2251;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2251; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2251;4:jEc8Zd0oi1zz77Zczi87lNi37jh2/paxufwJ4QnRlw7SbiEUwFym0TLAGLR5nBi7wCmiSNecHDU4SuWwyJFCJDbP1FDgJwXPzBfCcl/PIuge9Crw+D8Eewes8MQ74sCbxTljVRtCwCBuhr2LD3EklOLRb5FKkyaTsL2wzymXrdUEGcV1F1tMZTRFSoUbH3xfMngMNnbY2TLc29VcBD6xq6Jltl4Au2V5ag0poxuD8KlAcmNNPp7pBwKRRjHpvS+JL6DWQ/RCHrLwv351FWUbYu+uDeSV+5f4sSV+6GeTp4ZuioQVca4sEHgmabEsBiNn4Kw9Z5QkjiAz7IEAvTa3EGVna9zaSdxOwcZ+cpjgqxQ6/k9MmqSM3U2vxOB2xwA+ X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(52314003)(24454002)(42186005)(47776003)(9686002)(97756001)(2950100001)(19580405001)(92566002)(19580395003)(7846002)(33656002)(83506001)(76506005)(8676002)(1076002)(77096005)(81166006)(4326007)(101416001)(68736007)(107886002)(110136002)(2906002)(189998001)(50986999)(586003)(97736004)(66066001)(76176999)(23726003)(50466002)(54356999)(106356001)(4001350100001)(4001430100002)(33716001)(6116002)(81156014)(3846002)(46406003)(105586002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2251;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR07MB2251;23:fJtxX9xgnTqgBWSegM058Y812ZqFdrIJCpt9jgkEu?= =?us-ascii?Q?iOgb/pANvFRM4rgjPK4Km56mRrtNv3y2rOFyxmusOK7+imkOWiBFwwULfgAK?= =?us-ascii?Q?5+VyDSfeUMAPL7v2NrV+mga1AFHBSFAb1w/ueX3afI7IZeR6bdon5HqiS3ZN?= =?us-ascii?Q?EnbnRSqEBmBelsf4fZvDWk7hiiqoCdUCTY//gl+xFHvQ6H2XAR9zodHT75eY?= =?us-ascii?Q?jb8rWvSnzV1e31zpGRGnKZccSj8w3JkOZQBsxAK4NaXnKV3pG1GR0ITQ5yti?= =?us-ascii?Q?wZtqX03vkMOCRT9TuykaWcQ31gt6WwrNprDlFZi0EAGcDA7VfPshMqM1R9eQ?= =?us-ascii?Q?SK9Zo7t3LgaYPQjFysjpMjtolAOrrWxu2G1lVLSYRu31vPIM6PEZUDRwikS3?= =?us-ascii?Q?1DAEpUlKDuPpY+DYGLHyDCPvo0vjfD2D6EYNbprwzjWA0/M6oB+gnLDZtpMJ?= =?us-ascii?Q?2PmbGDvztNvItHUDzTlicU8eChZ/mjJ75NC710mJv4yDJfCPFLYceLqXkni5?= =?us-ascii?Q?uPETT/81unMQQeCLFOexx2DovGVqFNv/VjJFyza+n4ekmOK19f8VWrqkuSWZ?= =?us-ascii?Q?E3hG0EVMpUcLFBOYkJTLBxpH9xtQ2+rE5J+laUX+EUlNrzGC6R91v1H2XjQP?= =?us-ascii?Q?6kkSDZjHcPWSi/0ZocuDFOOKa76+O3KMUGV6Xwg7GfDJiUS0QaHuKo0QOAKR?= =?us-ascii?Q?iWfutoqbP66U4E7bZDlkYBu+ah3VnsuexSfghFC1/HRjZhnw4cWQpvbV6KdZ?= =?us-ascii?Q?I8HGIk4+XA4jlpgwT33w/IZz6a//EWN6I/7YGQ3bEz6tBqnYKtS+ndbkk2J2?= =?us-ascii?Q?08Qd6dS4vGZY+K202vzYJK518/kIJScpE2hp2MeinTrNlsA5NqwvO3r+KKBc?= =?us-ascii?Q?cBh6CzzrY+YNWf/v2mKejowbWSgm4wUNOKP33NeR2lGhT1g6uy1tq0KflIBd?= =?us-ascii?Q?6iNNOU8Wpd6HKUODWNBqEUN7nqQtNI0mDyGOxYtgwgb+qp963VRcMoeFrmUl?= =?us-ascii?Q?lkY3P2UQmwF4OEF8xiLrJfF4xWruUau6J7IPwqXTjXl7iY8UI9b6ovVOCchK?= =?us-ascii?Q?etgZ5T/iQWC8OTb2SDgH8tCvQZOdnHAbN+QzUOOAcvgh0LAIfaD2eGDXLUdo?= =?us-ascii?Q?qfEOMju0JoTKoHb/x5oHD7r7hlGjZ6WjvIRMnlxafaXx6jVrW5abAjCF9EKG?= =?us-ascii?Q?0Zv5OnT/w0G1wVVUsQpoadrNBfE90pgTTYekutPN+1HV9Od49ssu2xroA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2251;6:c2YgAxmGJJ9WzM6YGoPrTC1TssAhAe3yHkfOZ2AV64cMJYH0qQvFo7MqdOigevs6fHO6WhLPCrktfWQoIE9kLHwcoaTTJDAyXv+KBFy98crue5JARvkq1wPZMgB/2uc4GzJy99CWITA9m1e0IE9RGpCml6pA3/Pm3I7JK4Y68kvE3rWxW5UnWPFntC7K6we5NGIUsZ+CYLiXgAbK5cinAdeqZWh7QpE1boW5UlGm+e9W/Lb55pfehoMnMFEjiuVPbTTQqSFIdQAkl/bGORfbrg5v0Yw8QMKUk9td1HylC54xVah/Lw1cSekp9/dFDbSs;5:meiA+X/sVkuAj48/njh8hWOSFIZS6jHRGiLd6XNSiFcDx3+J9G7+rnwauTcmFAJRWjuvd5QjRaK6E89pkg5h6oYpchUUGpSWUGt78vtxZrSlhoCs90PrnCylYsDj9iY+Dvc11/jd19nHSKbUN5hI5A==;24:joZIAt7SP7g3NTfW36PS0xuQsVT0u89yC9//CM4CF0guEmh9VosmSzZ+aRAWEL4B5mGrX0yymbCJxDiLctElnS4sV2AE8pyZ2qmZpe5Y3Yg=;7:51kbPl6WzTf5+RRcEp1qIcLMqYy4hKrHbn2IP9gxE524sb19TitOl8KrQnEyGDqG++9M7GdHnoO6RwsIfdxe/n3JlqhYNuD2hJxoJ2xx6ZdOdFeNMCfKYJJ9QP8jDYPobV1u6hwzu66N0aZ03tzakuJQnhD2TwyJuRwZRvvrNMRywUHlG6KTEkRI7CLb6LXKnAl4LHBWlZCcHTilH8XFFEV8ZnaGHMzCYJVGLvavpNCSExUX9+8uEXk1n1oTKjke0a0LiwpANPmchmKdPn0izg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 06:02:37.2457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2251 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote: > On Tue, 21 Jun 2016, Yury Norov wrote: > > > +#ifdef __LP64__ > > +#define RTLD_START RTLD_START_1("x", "3", "sp") > > +#else > > +#define RTLD_START RTLD_START_1("w", "2", "wsp") > > +#endif > > As well as preprocessor indentation, this is missing spaces after '('; > check for and fix that issue throughout this patch series. (There are > only a few cases where a macro is used to construct a type / variable > name, such as ElfW, where missing the space is more usual.) > > -- > Joseph S. Myers > joseph@codesourcery.com So, you want have it like this? #ifdef __LP64__ # define RTLD_START RTLD_START_1( "x", "3", "sp" ) #else # define RTLD_START RTLD_START_1( "w", "2", "wsp" ) #endif Pretty contr-intuitive to me... Anyway, I follow it.