From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbcFVMI6 (ORCPT ); Wed, 22 Jun 2016 08:08:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45873 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752465AbcFVMIz (ORCPT ); Wed, 22 Jun 2016 08:08:55 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Wed, 22 Jun 2016 05:08:53 -0700 From: "Paul E. McKenney" To: Jisheng Zhang Cc: josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] rcu: Use rcu_gp_kthread_wake() to wake up grace period kthreads again Reply-To: paulmck@linux.vnet.ibm.com References: <1466587167-3541-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466587167-3541-1-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062212-0024-0000-0000-000013F30040 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062212-0025-0000-0000-00004209A086 Message-Id: <20160622120853.GI3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-22_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606220130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2016 at 05:19:27PM +0800, Jisheng Zhang wrote: > commit abedf8e2419f ("rcu: Use simple wait queues where possible in > rcutree") converts wait queues in rcutree to use simple wait queues, > but it incorrectly reverts the commit 2aa792e6faf1 ("rcu: Use > rcu_gp_kthread_wake() to wake up grace period kthreads"). > > This patch tries to fix the above issue by useing rcu_gp_kthread_wake() > to wake up grace period kthreads again. > > Signed-off-by: Jisheng Zhang Good catch! Queued for testing and review. Thanx, Paul > --- > kernel/rcu/tree.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index c7f1bc4..c270ce0 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2333,7 +2333,7 @@ static void rcu_report_qs_rsp(struct rcu_state *rsp, unsigned long flags) > WARN_ON_ONCE(!rcu_gp_in_progress(rsp)); > WRITE_ONCE(rsp->gp_flags, READ_ONCE(rsp->gp_flags) | RCU_GP_FLAG_FQS); > raw_spin_unlock_irqrestore_rcu_node(rcu_get_root(rsp), flags); > - swake_up(&rsp->gp_wq); /* Memory barrier implied by swake_up() path. */ > + rcu_gp_kthread_wake(rsp); > } > > /* > @@ -2961,7 +2961,7 @@ static void force_quiescent_state(struct rcu_state *rsp) > } > WRITE_ONCE(rsp->gp_flags, READ_ONCE(rsp->gp_flags) | RCU_GP_FLAG_FQS); > raw_spin_unlock_irqrestore_rcu_node(rnp_old, flags); > - swake_up(&rsp->gp_wq); /* Memory barrier implied by swake_up() path. */ > + rcu_gp_kthread_wake(rsp); > } > > /* > -- > 2.8.1 >