From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Jens Axboe <axboe@fb.com>, Mike Christie <mchristi@redhat.com>,
Andy Grover <agrover@redhat.com>, Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] target/iblock: use ilog2 to compute block size
Date: Wed, 22 Jun 2016 06:38:09 -0700 [thread overview]
Message-ID: <20160622133809.GA29657@infradead.org> (raw)
In-Reply-To: <20160622125534.1267407-1-arnd@arndb.de>
This doesn't compute the block size, it computes the number of block
in a block device. I think it would be useful to add a generic helper
(e.g. in blkdev.h) as this calculation seems to be open coded in various
places.
next prev parent reply other threads:[~2016-06-22 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:55 [PATCH] target/iblock: use ilog2 to compute block size Arnd Bergmann
2016-06-22 13:38 ` Christoph Hellwig [this message]
2016-06-22 15:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622133809.GA29657@infradead.org \
--to=hch@infradead.org \
--cc=agrover@redhat.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox