Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

Pali Rohár
2016-06-07T23:00:23Z

On Friday 27 May 2016 00:04:23 Gabriele Mazzotta wrote:
> On 22/05/2016 13:36, Pali Rohár wrote:
> > ACPI DSDT tables have defined other WMI codes, but does not contain any
> > description when those codes are emitted. Some other codes can be found in
> > logs on internet. In this patch are all which I saw, but lot of them are
> > not tested properly (e.g. for duplicate events with AT keyboard). Now we
> > have all WMI event codes at one place and in future after proper testing
> > those codes can be correctly enabled or disabled...
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > drivers/platform/x86/dell-wmi.c | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> > index 363d927..7aac1dc 100644
> > --- a/drivers/platform/x86/dell-wmi.c
> > +++ b/drivers/platform/x86/dell-wmi.c
> > @@ -110,6 +110,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
> > /* BIOS error detected */
> > { KE_IGNORE, 0xe00d, { KEY_RESERVED } },
> >
> > + /* Unknown, defined in ACPI DSDT */
> > + /* { KE_IGNORE, 0xe00e, { KEY_RESERVED } }, */
> > +
>
> I'm interested in knowing what's the meaning of this 0xe00e. This
> event is sent multiple times when I suspend/resume my laptop and
> it's definitely not a keypress.

>From DSDT dumps which I have seen, I guess it could be something with
battery charging... but that is only my guess.

Mario, do you have any idea, what these unknown events are?

> Anyway, I've been using this patch set and didn't notice any issue, so
>
> Tested-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
>
> > /* Wifi Catcher */
> > { KE_KEY, 0xe011, { KEY_PROG2 } },
> >
> > @@ -118,21 +121,45 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
> >
> > { KE_IGNORE, 0xe020, { KEY_MUTE } },
> >
> > + /* Unknown, defined in ACPI DSDT */
> > + /* { KE_IGNORE, 0xe023, { KEY_RESERVED } }, */
> > +
> > + /* Untested, Dell Instant Launch key on Inspiron 7520 */
> > + /* { KE_IGNORE, 0xe024, { KEY_RESERVED } }, */
> > +
> > /* Dell Instant Launch key */
> > { KE_KEY, 0xe025, { KEY_PROG4 } },
> >
> > /* Audio panel key */
> > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> >
> > + /* Untested, Multimedia key on Dell Vostro 3560 */
> > + /* { KE_IGNORE, 0xe028, { KEY_RESERVED } }, */
> > +
> > /* Dell Instant Launch key */
> > { KE_KEY, 0xe029, { KEY_PROG4 } },
> >
> > + /* Untested, Windows Mobility Center button on Inspiron 7520 */
> > + /* { KE_IGNORE, 0xe02a, { KEY_RESERVED } }, */
> > +
> > + /* Unknown, defined in ACPI DSDT */
> > + /* { KE_IGNORE, 0xe02b, { KEY_RESERVED } }, */
> > +
> > + /* Untested, Dell Audio With Preset Switch button on Inspiron 7520 */
> > + /* { KE_IGNORE, 0xe02c, { KEY_RESERVED } }, */
> > +
> > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
> > { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
> > { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
> > { KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } },
> > { KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } },
> >
> > + /* NIC Link is Up */
> > + { KE_IGNORE, 0xe043, { KEY_RESERVED } },
> > +
> > + /* NIC Link is Down */
> > + { KE_IGNORE, 0xe044, { KEY_RESERVED } },
> > +
> > /*
> > * This entry is very suspicious!
> > * Originally Matthew Garrett created this dell-wmi driver specially for
> > @@ -145,7 +172,12 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
> > */
> > { KE_IGNORE, 0xe045, { KEY_NUMLOCK } },
> >
> > + /* Scroll lock and also going to tablet mode on portable devices */
> > { KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } },
> > +
> > + /* Untested, going from tablet mode on portable devices */
> > + /* { KE_IGNORE, 0xe047, { KEY_RESERVED } }, */
> > +
> > { KE_IGNORE, 0xe0f7, { KEY_MUTE } },
> > { KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } },
> > { KE_IGNORE, 0xe0f9, { KEY_VOLUMEUP } },
> >

--
Pali Rohár
pali.rohar@gmail.com