From: Leon Romanovsky <leonro@mellanox.com>
To: Saeed Mahameed <saeedm@mellanox.com>, Joe Perches <joe@perches.com>
Cc: Matan Barak <matanb@mellanox.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%
Date: Thu, 23 Jun 2016 08:27:01 +0300 [thread overview]
Message-ID: <20160623052701.GB30933@leon.nu> (raw)
In-Reply-To: <1466619839.13093.4.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote:
> The logging macros create a bit of duplicated code/text.
>
> Use specialized functions to reduce the duplication.
>
> (defconfig/x86-64)
> $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o*
> text data bss dec hex filename
> 178634 2059 16 180709 2c1e5 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.new
> 188679 2059 16 190754 2e922 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.old
>
> The output changes now do not include line #,
> but do include the function offset.
>
> Signed-off-by: Joe Perches <joe@perches.com>
As far as I see all these functions are used in error paths, so no
implication on performance is expected.
And I'm fine with function offsets.
Saeed,
What do you think?
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-23 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 18:23 [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5% Joe Perches
2016-06-22 20:40 ` Jason Gunthorpe
2016-06-22 22:20 ` Joe Perches
2016-06-23 5:27 ` Leon Romanovsky [this message]
2016-06-23 7:12 ` Leon Romanovsky
2016-06-23 8:12 ` Saeed Mahameed
2016-06-23 8:09 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623052701.GB30933@leon.nu \
--to=leonro@mellanox.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox