From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbcFWHMW (ORCPT ); Thu, 23 Jun 2016 03:12:22 -0400 Received: from mail-am1on0080.outbound.protection.outlook.com ([157.56.112.80]:54323 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751287AbcFWHMS (ORCPT ); Thu, 23 Jun 2016 03:12:18 -0400 X-Greylist: delayed 6307 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Jun 2016 03:12:17 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Date: Thu, 23 Jun 2016 10:12:10 +0300 From: Leon Romanovsky To: Saeed Mahameed , Joe Perches CC: Matan Barak , , , linux-kernel Subject: Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5% Message-ID: <20160623071210.GA23995@leon.nu> References: <1466619839.13093.4.camel@perches.com> <20160623052701.GB30933@leon.nu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <20160623052701.GB30933@leon.nu> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [213.57.247.249] X-ClientProxiedBy: AM4PR01CA0039.eurprd01.prod.exchangelabs.com (10.164.74.177) To DB5PR0501MB1928.eurprd05.prod.outlook.com (10.166.173.149) X-MS-Office365-Filtering-Correlation-Id: b8632391-2b4f-4137-7f04-08d39b35b42e X-Microsoft-Exchange-Diagnostics: 1;DB5PR0501MB1928;2:TOqA/k5cFN1/tP3olJIFrMvBgcKeeoqmhwtQztFV0REB44N8F0AOi4l4l9vBJ/XOCEykS+0RqIVHilfrpOkqNjE5+b2byrP8tMlSyZ3BZ61eV8RaT+7NcTrWJ8km03ifbA9NheEuPTvCOL4X4VJq6gRBiUkcCenNsCe2Bb7oEqGHIviSsBj/Gb8Uvm9zxFCN;3:297cDXWjyuYwHcHsWpgdFEQBR9ru1ujYpjrozMfMi+Hfjg3LZKCppaO4lrMJwHiC7HSbqae01iM+8etju49Zx235Kb3mAIa2UThSsfJXD28KdVFl84GIELnqGhcDkZiM X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0501MB1928; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0501MB1928;25:hIUT9cMKCi5mqHD/I2wq1H/P5b52vD5P/svIcXujzO3/q2RN/AbBsJjpmZ83GYfbMQCTkXq08SGkj9WbpvfUHMuD4tEQ4TYIq9yZVYqafgAgR1a4SXBV5IZFKu+nrViVfVYrIZI4AW1HNuVkDzNhcRLUVnUCFIffSuXGfAPyEcUZ85O+XfRNLl+UwLIlOcnbeKFaB3TwAf9ndCrdFayCtA1bJ8Q6+cBUUIfEP6vkGcRX+el9PTHI6yvraTQHXqkVoHX1cfEUhZMqf8FBB8ZWWMD9aXGydtZrmu8L1TZTvhbusu9l/e3LvlzuEbu+RzAR2ZYbvCWa28KXKjbrjj3uh+cEcSSrtWsqfIAJ05AW+YAkOQRrxcqx1EtDtpmTfNYnQCwJQUV0nUpT24hXYbGB6kHrw/+zD4UOgWwUKfS9kh2N/6WNcTdxn9jvD3L5vdm4eBW0QxtcrWehLqZYUV8vaeONMwOJAOlGUrpyrCKfoYhCoEsozpSKR6FJmj+VGBdFM7kKMREeBnjBy2T8tBYmDaC3IPpgRxTRYN8le7wP+vBKo3E9GRdHaTEIEMW8q6feiRcdTNbZTigIQb61eJXtg03URj7SOTyCDLGjehYxkb4oD2dd8r7L/EutV75XDWjxJFov3kZpB/NqSAjIE0SXDtaMwOokyRpCvg06q7Ko7H5OWp/hjdUIDf/BfueTFlzjAqyaFeOO77t78aHtbeLrXjJFmLWuM9npf7d63RIHaYQZE4/jojHBZ5SUcU6xurctPa1VbexyB4sHXU3eXQcVuaFyX4BiAgOucWsZ0q1Y91lo1HAVupMLQKKJu1iwOvzG X-Microsoft-Exchange-Diagnostics: 1;DB5PR0501MB1928;20:cMPKfnXd3N0eAZb1XOdjsOFs8td2HWM/Zk3NucBoc00CnQNYmDGBJeR8RNr5znJGH0jC9AzoxRGCDVDR+3G+W7WyKGUeALktqLvUQ3R88zOJtlk6kgF/63PSZyiF4sb+EIAVx1v2GR/dJ14lyiilM4o54TjnOX995rFnbcVFwxsKTJca4Wart4256/W16+Q4OxEs/RoMDTc9vZcYpX5WKalCv6HcOaxEY7CEqSXK935D98AOFORMGGebu+atchyocqGJs+PuMdiHxcTV2zvnj2UOIho7HHZLnk2kd6aZuAAnMg6P8PkbK7OKogNnCE9++WMR64WrwMJSbe8KzVeMll2uYm7l3+Jkva9ll1p2AMoaliKku/fH907zUrfK5SkNXDbCroI+rLPmo3MZglfawdpUwRrstZZm8qdGyVzKDvqkYcgzujVott7yah7+NaJiZnu6XHsJv6B4UPCUOtXyTNrLFomm4dV5PK0Q+MJqPgWtJZvFYH/b1El/xR/u0B/9;4:vxFCRPtb2u27z4ILtWz8h5tIHnykkY4QBDiOWRSWXND8DBtXHQNEkAA74Q4TQTuE44y9TZB+J8zGqSoaz7bEDu53EpV7QO6CeAm7cSvccmUqqVgt1gT04Dxy51VuLY/2UO/sH+In0HNN+Lj3s7Udq3L4/poflJz4bdgdPsfKZa6wkfivZRZRtvoAnhAGbDLXUmcabzCtGVwFJ4+377RfC5ZvjK5UhBAZtG7wxMnrYsbX58QCdcXWuWq8idn8V6As/We3AQB83oExpmef6338+/svDGjqqm6i/A+6crcCVOIEdlIDBALyN/0PtwEfmWa99/oE6ouRUhYK5QmGgs7s41EcBLUTUbGD5Axa8wIgnqo6T7uqUm6HPjGym3L530lpTWcFAmITuxvrDrqxYQY6uA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DB5PR0501MB1928;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0501MB1928; X-Forefront-PRVS: 098291215C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(24454002)(189002)(199003)(76104003)(24434003)(42186005)(101416001)(6116002)(3846002)(83506001)(19580405001)(86362001)(586003)(36756003)(66066001)(19580395003)(92566002)(2950100001)(76506005)(84326002)(77096005)(81166006)(8676002)(2906002)(4001350100001)(4326007)(50986999)(76176999)(54356999)(81156014)(512874002)(97736004)(9686002)(5001770100001)(106356001)(105586002)(68736007)(21480400002)(305945005)(33656002)(7846002)(7736002)(1076002)(189998001)(2700100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR0501MB1928;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA1MDFNQjE5Mjg7MjM6eEdVbXFVQnNLWUlOalBsbWFEOEFtd3kz?= =?utf-8?B?ZXF5ZGNGZUVlVE0rZC8zS285Y0V1ZUtGNlFPeTd4VUx1OFlET0pvbitaUEtR?= =?utf-8?B?NDNtVnpKMGdVdHk3bWtENmFBN25GeHpwNDhVenhXKzlSM1dZaTFmZjZsT0xq?= =?utf-8?B?WTc4RGswMWRYNUZtTmJUT2xWcWdycEtxaXdleExnV1RXN0VyditodXZLZnhi?= =?utf-8?B?VnlvNlAwTTdaMSt4OXg0MThYQThMZCtkRXB1ZHhhV29vQWNtYXB3QS9kQnpD?= =?utf-8?B?VFFpS1RvdWZwQnE0UUdtK1ZrS21JSFRHak1lQ1BVbnhBWDJoMStCVkxOVDl6?= =?utf-8?B?TFhYZU5RYWpkNzcydXZVbFZYdUY1UUdmUmpoZ3crMzdqTENvdUw0MVYvNng1?= =?utf-8?B?dVRZNm16RVRNbmhNeGt5dVh1YUE4Ym0rYUpKMEhCVUZXbDRUOVBNNVFrOEZX?= =?utf-8?B?bFFseGFXbUZzQkJxN3JQWTVvYVB4eVgwdzFHUUh4TjJyNVlmOFVGbVdTYm5S?= =?utf-8?B?dUdiZHpZQ2hlOEhZeml3aWhTVitLd3FJUERHNjd1USt1L1dWSnBCTzlueGNQ?= =?utf-8?B?eFo4cStGLzV6S0ZXWXg4Mm5rNTNhZXJpRDFNdXdxa0ZQbjFPbFdxd0tncTY4?= =?utf-8?B?SjgvSFNUVDdLaVlqUWhRVTE5WDRZejZGdXJRMEx2QUw1UHBPeUhoZldsS3Ix?= =?utf-8?B?YjFra1NZNWlaNHRabjFvRHdUM0lWK2pDWFltWHZ2SlM0VFFUMHhFNnJpTW1y?= =?utf-8?B?d0dnNFp3WUM4cEM0VGJhb21aWHBGNEFYWXNkaVYxWnBNeE1jRWphdUZVUDdt?= =?utf-8?B?aU0rOFJ6R3Nxc2p0ZDRoZU12NTVoZEhRa0JxZGF5MGFqWGFGclhoTml3OTJ6?= =?utf-8?B?V01PVDYyNUxleGRqNzhQeXlTQWhMTzRHM24wTWJITy9hUThXN21JcCt3NlRW?= =?utf-8?B?dzJVcXlqYTV2dXVjTEs3N09GOERyTHk2TUhWb0FJN3hVemhrbTI5blQydkJM?= =?utf-8?B?amttcVNLQ0ZQU2pyWHc5d0hSUnEvQjFQbTBKVUFYc1dXM1RhYUpIZjFWVi9X?= =?utf-8?B?WmtxbUgxSUw4NVZlUGt5MTNCU3ovUGZraUx4UGo3dmUwSVRTa3l6d0RBTlQz?= =?utf-8?B?a3VWcFJ6cHErdkZ0d1BOeFNUa09NcUQrcVRXMFIxSGljK0Z6U004cDBjbjZh?= =?utf-8?B?RVJMMWFOUzFZR3B6ZnRDb09DMThiL0NpbUFrdjBEUiswbGJoZHpWQUxDZmJQ?= =?utf-8?B?UnVRZ2xuTEg5Sk1qVFNpbDFqOC9qeUJQdlZNcTlLUkViNFNtd3REb1RBMTF1?= =?utf-8?B?NC9WVXNXMHhOa0dJS3RROEt3VVZTc0NORjNabHhwWUV6UGkyaUJQRUM4QmhD?= =?utf-8?B?TVQrSXVRc09PeVYvQ3Z2U2dKc3g2NXVKSEZUWUtEdTEreHk4eU5ZVlJ5RWgz?= =?utf-8?B?RzhOeGVzVHpadnl2SVh1UUVvTVFraXB0YldrdEdoelZMVVZUYWNjRGp1cVRM?= =?utf-8?B?QXVDdzFZeHY4NTdCUVYycXhsZUFJUkQ1TmVMMXkrMkVrdGUyNkFTdktUWVVr?= =?utf-8?B?SFVudUE0K2t3Y3E1Wk9rQXppbVBtTzFLaDF1WFIzeXMwZWpZdFB0dVB2Q1lx?= =?utf-8?B?aVZTZWZVN1JXRys0aGFxa0dzaXg2Sm5VV2xTNmZPZVArcHlUbHlNSDNZa1E9?= =?utf-8?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0501MB1928;6:aJSgo1FeFuhiv/37sArXeJ7OoQZ2miOcuWYVyPcfUBRIQHSlX+vj4wVZTwUWiIC+DreOPn+xonDsu4gthISxI/NtF6QGeOKPJf7YRZAWKKCGGghCkzJ+xParmdIy9MvIkqC6AuTNy+7E4aswB9Mief7Sg8N2QBCHhPhRM0bGywj6Qb24060pdy55TbweZX0n0eSdhyYDsjdbclIgenI8yKgsW1UiBLDPMIlr6Vp9w5FhdbVFbHIxK5WL6sIKzkXdw+7prsO9X76mEIRzJ9gGhySUYjkSbqzJmeur6MaQLxbLOJ8u0KB07JbVf7sgBtgL+O2z4NxbcvW/d4NU0wRNmeuFs5ieQGnPc0/jNdlJ13w=;5:jRvdnvbxSjhkVsZtnICG9xcFWCA3h/0tboEK0Q9tqe7tag6HATE5OssPjGfaDKU4neX3hn8U7bbdVg0FSN/zVWicLk6YzSpny94f3LOme/4TsDkvssRt0uPXOJjsL1g5zZVa86eENnlk09T5cRaYrQ==;24:lfAdivS/iGlsUblst9hpEV1o2BMhaifwqZ9qsxTRwH12Bu0GLz/eXVCcMsWCMqRk1WcNAc/Rtfd8KtnDCAlS5js+onqRx7uNPlkfwbq/+IU=;7:o6iX+Psy5uAvm2scBxJvCbd9yC0pUYOPvJpj5wF9nS0Ze+xF957XFsuLMNRzPjgBhc3b6KpFRroeSTtX5ZBAD3eV796qndPOwUmGMtMR82jY2JGrQMZY+7GDtkIdOaMVxXr4U2amVMOXd6yTpfR9DDLWENIXfnhVsxpulGevnhC5qgo0C0aT8M+qlsiVi2w35WMQfTQrq+BBP+jxJmWIAVg64KOIlGTRFxHSv5f/GNapwYdtpi+rnJWWfUSSS7nsI8DrmRc3rbvPlMG9S+pvng== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2016 07:12:14.4767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0501MB1928 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jRHKVT23PllUwdXP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2016 at 08:27:01AM +0300, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > > The logging macros create a bit of duplicated code/text. > >=20 > > Use specialized functions to reduce the duplication. > >=20 > > (defconfig/x86-64) > > $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o* > > =C2=A0=C2=A0=C2=A0text =C2=A0=C2=A0=C2=A0data =C2=A0=C2=A0=C2=A0=C2=A0b= ss =C2=A0=C2=A0=C2=A0=C2=A0dec =C2=A0=C2=A0=C2=A0=C2=A0hex filename > > =C2=A0178634 =C2=A0=C2=A0=C2=A02059 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A016 = =C2=A0180709 =C2=A0=C2=A02c1e5 drivers/net/ethernet/mellanox/mlx5/core/buil= t-in.o.new > > =C2=A0188679 =C2=A0=C2=A0=C2=A02059 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A016 = =C2=A0190754 =C2=A0=C2=A02e922 drivers/net/ethernet/mellanox/mlx5/core/buil= t-in.o.old > >=20 > > The output changes now do not include line #, > > but do include the function offset. > >=20 > > Signed-off-by: Joe Perches >=20 > As far as I see all these functions are used in error paths, so no > implication on performance is expected. >=20 > And I'm fine with function offsets. >=20 > Saeed, > What do you think? >=20 > Reviewed-by: Leon Romanovsky I continued to play with this patch and it doesn't pass checkpatch. It looks like corrupted file. =E2=9E=9C linux-rdma git:(master) ./scripts/checkpatch.pl ~/Downloads/mellanox-mlx5-Use-logging-functions-to-reduce-text-10k-5.patch WARNING: Possible unwrapped commit description (prefer a maximum 75 chars p= er line) #21:=20 =C2=A0178634 =C2=A0=C2=A0=C2=A02059 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A016 =C2=A0= 180709 =C2=A0=C2=A02c1e5 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.new ERROR: patch seems to be corrupt (line wrapped?) #46: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1556: CHECK: Alignment should match open parenthesis #78: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1586: + dev_warn(&dev->pdev->dev, "%s:%pS:(pid %d): %pV", + =C2=A0dev->priv.name, __builtin_return_address(0), current-= >pid, ERROR: space required before that '&' (ctx:VxV) #79: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1587: + =C2=A0&vaf); ^ total: 2 errors, 1 warnings, 1 checks, 58 lines checked --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXa4vKAAoJEORje4g2clinSkoP/2Y+3JlC32z5UczfyknEMt4K nHa0/RzSlaM0dOms8ujawisj/FAtFSTyd4hWLz4/Ogd+IM6YJcjrSXHVGoqgPqW5 oSBtvO2WMePHG9oI2LoY9+C1Pv9d5t5EEU0vhQgpzihWeLDWSxL1pjY3eI1Ny03L jcYzbG39D91r5vK7u+sksb9QclqQizBtsMVskMqaVLOv70V//uGQ2uwx53pb7fRU P7EVGM2M3gqAr0N1aNn0f1FDd8kaCvwFdPbVPI/wGaEwkjVK6CoZdHKRwskx3gBk JmuhfBk+LhKN2tcpNhj9g7kPuY9rfxqvBN4etxPATyzTiV0s8qM0GZXSRU92sjsr Q7NtlxxmBNun0dGiqczQHPhtk1GNKtpx8ObPNU9fvQf8QC1HgxGttpyxkE0MF+kw j4IA3ekGcDKGNIgp4u5SLhh5xdNRTSmD2Iu4vBFJSqUjYmV6g+9EBROfBefoPOg5 yqGofrgaNWyR/zWWyybneha+DCi5YCnNIRN8SQuVy7sx4u+5vVa+NJ9tJ2/e4FHU leXNcoVrA9DcqGVBhu+Gld/T98dSLQpVCqDyhUEk2ttCneBb7UIwjKDhECFsCzeH 7VGFCg8wBcP6jNz2Y524KW9gde4dt74wGaR/z6/00+DIPOYkU2T57ZmLgbAs9Ugf VRgzFF3YG8H/pxeHinV5 =LXfB -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--