From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbcFWN6Y (ORCPT ); Thu, 23 Jun 2016 09:58:24 -0400 Received: from outbound-smtp11.blacknight.com ([46.22.139.16]:35667 "EHLO outbound-smtp11.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbcFWN6X (ORCPT ); Thu, 23 Jun 2016 09:58:23 -0400 Date: Thu, 23 Jun 2016 14:57:58 +0100 From: Mel Gorman To: Michal Hocko Cc: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , Johannes Weiner , LKML Subject: Re: [PATCH 19/27] mm: Move vmscan writes and file write accounting to the node Message-ID: <20160623135758.GY1868@techsingularity.net> References: <1466518566-30034-1-git-send-email-mgorman@techsingularity.net> <1466518566-30034-20-git-send-email-mgorman@techsingularity.net> <20160622144039.GG7527@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20160622144039.GG7527@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2016 at 04:40:39PM +0200, Michal Hocko wrote: > On Tue 21-06-16 15:15:58, Mel Gorman wrote: > > As reclaim is now node-based, it follows that page write activity > > due to page reclaim should also be accounted for on the node. For > > consistency, also account page writes and page dirtying on a per-node > > basis. > > > > After this patch, there are a few remaining zone counters that may > > appear strange but are fine. NUMA stats are still per-zone as this is a > > user-space interface that tools consume. NR_MLOCK, NR_SLAB_*, NR_PAGETABLE, > > NR_KERNEL_STACK and NR_BOUNCE are all allocations that potentially pin > > low memory and cannot trivially be reclaimed on demand. This information > > is still useful for debugging a page allocation failure warning. > > As I've said in other patch. I think we will need to provide > /proc/nodeinfo to fill the gap. > I added a patch on top that prints the node stats in zoneinfo but only once for the first populated zone in a node. Doing this or creating a new file are both potentially surprising but extending zoneinfo means there is a greater chance that a user will spot the change. -- Mel Gorman SUSE Labs