From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751265AbcFWOaf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jun 2016 10:30:35 -0400
Received: from mail.kernel.org ([198.145.29.136]:58796 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750866AbcFWOad (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jun 2016 10:30:33 -0400
Date: Thu, 23 Jun 2016 11:30:28 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v11 2/3] perf config: Reimplement perf_config()
 introducing new perf_config__init() and perf_config__finish()
Message-ID: <20160623143028.GQ4213@kernel.org>
References: <1466687020-21198-1-git-send-email-treeze.taeung@gmail.com>
 <1466687020-21198-3-git-send-email-treeze.taeung@gmail.com>
 <20160623133827.GO4213@kernel.org>
 <576BEF15.9020405@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <576BEF15.9020405@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Jun 23, 2016 at 11:15:49PM +0900, Taeung Song escreveu:
> 
> 
> On 06/23/2016 10:38 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jun 23, 2016 at 10:03:39PM +0900, Taeung Song escreveu:
> > > +/**
> > > + * perf_config_sections__for_each - iterate thru all the sections
> > > + * @list: list_head instance to iterate
> > > + * @section: struct perf_config_section iterator
> > > + */
> > > +#define perf_config_sections__for_each(list, section)	\
> > > +        list_for_each_entry(section, list, node)
> > > +
> > 
> > I was almost applying this but then there is a little detail, which is
> > that it is a goal to make the tools/ code look as much as kernel code as
> > possible, to encourage kernel developers to contribute to the tools
> > codebase and also to expose userspace developers to kernel practices.
> > 
> > With that said, please rename these for_each macros to for_each_entry,
> > i.e.:
> > 
> > perf_config_sections__for_each_entry()
> > perf_config_items__for_each_entry()
> > 
> > As for_each and for_each_entry both exist in the kernel and have well
> > know semantics that we want to keep.
> > 
> > Probably there are cases in tools/ where we break this rule, I'll check
> > and fix.
> > 
> 
> Granted ! :)
> 
> I sent v12 with above changes a moment ago.

Thanks, I've just converted evlist__for_each* and strlist__for_each to
this format.

- Arnaldo